Skip to content

Commit 9c27488

Browse files
avsejavsej
committed
Fix boolean typehint on function signatures
Change-Id: Id6f072d69df5446f320eeb59a78e2d2c06552ade Reviewed-on: http://review.couchbase.org/109847 Tested-by: Build Bot <[email protected]> Reviewed-by: Sergey Avseyev <[email protected]>
1 parent 8cd4dfc commit 9c27488

File tree

5 files changed

+29
-29
lines changed

5 files changed

+29
-29
lines changed

‎src/couchbase/bucket/get.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ ZEND_ARG_TYPE_INFO(0, arg, IS_LONG, 0)
9494
ZEND_END_ARG_INFO()
9595

9696
ZEND_BEGIN_ARG_WITH_RETURN_OBJ_INFO_EX(ai_GetOptions_withExpiration, 0, 1, \\Couchbase\\GetOptions, 0)
97-
ZEND_ARG_TYPE_INFO(0, arg, IS_TRUE|IS_FALSE, 0)
97+
ZEND_ARG_TYPE_INFO(0, arg, _IS_BOOL, 0)
9898
ZEND_END_ARG_INFO()
9999

100100
ZEND_BEGIN_ARG_WITH_RETURN_OBJ_INFO_EX(ai_GetOptions_project, 0, 1, \\Couchbase\\GetOptions, 0)

‎src/couchbase/bucket/subdoc.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -196,7 +196,7 @@ ZEND_ARG_TYPE_INFO(0, arg, IS_LONG, 0)
196196
ZEND_END_ARG_INFO()
197197

198198
ZEND_BEGIN_ARG_WITH_RETURN_OBJ_INFO_EX(ai_LookupInOptions_withExpiration, 0, 1, \\Couchbase\\LookupInOptions, 0)
199-
ZEND_ARG_TYPE_INFO(0, arg, IS_TRUE|IS_FALSE, 0)
199+
ZEND_ARG_TYPE_INFO(0, arg, _IS_BOOL, 0)
200200
ZEND_END_ARG_INFO()
201201

202202
static const zend_function_entry pcbc_lookup_in_options_methods[] = {

‎src/couchbase/lookup_spec.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ PHP_METHOD(LookupGetSpec, __construct);
2828

2929
ZEND_BEGIN_ARG_INFO_EX(ai_LookupGetSpec_constructor, 0, 0, 1)
3030
ZEND_ARG_TYPE_INFO(0, path, IS_STRING, 0)
31-
ZEND_ARG_TYPE_INFO(0, isXattr, IS_TRUE|IS_FALSE, 0)
31+
ZEND_ARG_TYPE_INFO(0, isXattr, _IS_BOOL, 0)
3232
ZEND_END_ARG_INFO()
3333

3434
zend_class_entry *pcbc_lookup_get_spec_ce;
@@ -41,7 +41,7 @@ PHP_METHOD(LookupCountSpec, __construct);
4141

4242
ZEND_BEGIN_ARG_INFO_EX(ai_LookupCountSpec_constructor, 0, 0, 1)
4343
ZEND_ARG_TYPE_INFO(0, path, IS_STRING, 0)
44-
ZEND_ARG_TYPE_INFO(0, isXattr, IS_TRUE|IS_FALSE, 0)
44+
ZEND_ARG_TYPE_INFO(0, isXattr, _IS_BOOL, 0)
4545
ZEND_END_ARG_INFO()
4646

4747
zend_class_entry *pcbc_lookup_count_spec_ce;
@@ -54,7 +54,7 @@ PHP_METHOD(LookupExistsSpec, __construct);
5454

5555
ZEND_BEGIN_ARG_INFO_EX(ai_LookupExistsSpec_constructor, 0, 0, 1)
5656
ZEND_ARG_TYPE_INFO(0, path, IS_STRING, 0)
57-
ZEND_ARG_TYPE_INFO(0, isXattr, IS_TRUE|IS_FALSE, 0)
57+
ZEND_ARG_TYPE_INFO(0, isXattr, _IS_BOOL, 0)
5858
ZEND_END_ARG_INFO()
5959

6060
zend_class_entry *pcbc_lookup_exists_spec_ce;

‎src/couchbase/mutate_spec.c

Lines changed: 22 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -29,9 +29,9 @@ PHP_METHOD(MutateInsertSpec, __construct);
2929
ZEND_BEGIN_ARG_INFO_EX(ai_MutateInsertSpec_constructor, 0, 0, 2)
3030
ZEND_ARG_TYPE_INFO(0, path, IS_STRING, 0)
3131
ZEND_ARG_INFO(0, value)
32-
ZEND_ARG_TYPE_INFO(0, isXattr, IS_TRUE|IS_FALSE, 0)
33-
ZEND_ARG_TYPE_INFO(0, createPath, IS_TRUE|IS_FALSE, 0)
34-
ZEND_ARG_TYPE_INFO(0, expandMacros, IS_TRUE|IS_FALSE, 0)
32+
ZEND_ARG_TYPE_INFO(0, isXattr, _IS_BOOL, 0)
33+
ZEND_ARG_TYPE_INFO(0, createPath, _IS_BOOL, 0)
34+
ZEND_ARG_TYPE_INFO(0, expandMacros, _IS_BOOL, 0)
3535
ZEND_END_ARG_INFO()
3636

3737
zend_class_entry *pcbc_mutate_insert_spec_ce;
@@ -45,9 +45,9 @@ PHP_METHOD(MutateUpsertSpec, __construct);
4545
ZEND_BEGIN_ARG_INFO_EX(ai_MutateUpsertSpec_constructor, 0, 0, 2)
4646
ZEND_ARG_TYPE_INFO(0, path, IS_STRING, 0)
4747
ZEND_ARG_INFO(0, value)
48-
ZEND_ARG_TYPE_INFO(0, isXattr, IS_TRUE|IS_FALSE, 0)
49-
ZEND_ARG_TYPE_INFO(0, createPath, IS_TRUE|IS_FALSE, 0)
50-
ZEND_ARG_TYPE_INFO(0, expandMacros, IS_TRUE|IS_FALSE, 0)
48+
ZEND_ARG_TYPE_INFO(0, isXattr, _IS_BOOL, 0)
49+
ZEND_ARG_TYPE_INFO(0, createPath, _IS_BOOL, 0)
50+
ZEND_ARG_TYPE_INFO(0, expandMacros, _IS_BOOL, 0)
5151
ZEND_END_ARG_INFO()
5252

5353
zend_class_entry *pcbc_mutate_upsert_spec_ce;
@@ -61,7 +61,7 @@ PHP_METHOD(MutateReplaceSpec, __construct);
6161
ZEND_BEGIN_ARG_INFO_EX(ai_MutateReplaceSpec_constructor, 0, 0, 2)
6262
ZEND_ARG_TYPE_INFO(0, path, IS_STRING, 0)
6363
ZEND_ARG_INFO(0, value)
64-
ZEND_ARG_TYPE_INFO(0, isXattr, IS_TRUE|IS_FALSE, 0)
64+
ZEND_ARG_TYPE_INFO(0, isXattr, _IS_BOOL, 0)
6565
ZEND_END_ARG_INFO()
6666

6767
zend_class_entry *pcbc_mutate_replace_spec_ce;
@@ -74,7 +74,7 @@ PHP_METHOD(MutateRemoveSpec, __construct);
7474

7575
ZEND_BEGIN_ARG_INFO_EX(ai_MutateRemoveSpec_constructor, 0, 0, 1)
7676
ZEND_ARG_TYPE_INFO(0, path, IS_STRING, 0)
77-
ZEND_ARG_TYPE_INFO(0, isXattr, IS_TRUE|IS_FALSE, 0)
77+
ZEND_ARG_TYPE_INFO(0, isXattr, _IS_BOOL, 0)
7878
ZEND_END_ARG_INFO()
7979

8080
zend_class_entry *pcbc_mutate_remove_spec_ce;
@@ -88,9 +88,9 @@ PHP_METHOD(MutateArrayAppendSpec, __construct);
8888
ZEND_BEGIN_ARG_INFO_EX(ai_MutateArrayAppendSpec_constructor, 0, 0, 2)
8989
ZEND_ARG_TYPE_INFO(0, path, IS_STRING, 0)
9090
ZEND_ARG_TYPE_INFO(0, values, IS_ARRAY, 0)
91-
ZEND_ARG_TYPE_INFO(0, isXattr, IS_TRUE|IS_FALSE, 0)
92-
ZEND_ARG_TYPE_INFO(0, createPath, IS_TRUE|IS_FALSE, 0)
93-
ZEND_ARG_TYPE_INFO(0, expandMacros, IS_TRUE|IS_FALSE, 0)
91+
ZEND_ARG_TYPE_INFO(0, isXattr, _IS_BOOL, 0)
92+
ZEND_ARG_TYPE_INFO(0, createPath, _IS_BOOL, 0)
93+
ZEND_ARG_TYPE_INFO(0, expandMacros, _IS_BOOL, 0)
9494
ZEND_END_ARG_INFO()
9595

9696
zend_class_entry *pcbc_mutate_array_append_spec_ce;
@@ -105,9 +105,9 @@ PHP_METHOD(MutateArrayPrependSpec, __construct);
105105
ZEND_BEGIN_ARG_INFO_EX(ai_MutateArrayPrependSpec_constructor, 0, 0, 2)
106106
ZEND_ARG_TYPE_INFO(0, path, IS_STRING, 0)
107107
ZEND_ARG_TYPE_INFO(0, values, IS_ARRAY, 0)
108-
ZEND_ARG_TYPE_INFO(0, isXattr, IS_TRUE|IS_FALSE, 0)
109-
ZEND_ARG_TYPE_INFO(0, createPath, IS_TRUE|IS_FALSE, 0)
110-
ZEND_ARG_TYPE_INFO(0, expandMacros, IS_TRUE|IS_FALSE, 0)
108+
ZEND_ARG_TYPE_INFO(0, isXattr, _IS_BOOL, 0)
109+
ZEND_ARG_TYPE_INFO(0, createPath, _IS_BOOL, 0)
110+
ZEND_ARG_TYPE_INFO(0, expandMacros, _IS_BOOL, 0)
111111
ZEND_END_ARG_INFO()
112112

113113
zend_class_entry *pcbc_mutate_array_prepend_spec_ce;
@@ -121,9 +121,9 @@ PHP_METHOD(MutateArrayInsertSpec, __construct);
121121
ZEND_BEGIN_ARG_INFO_EX(ai_MutateArrayInsertSpec_constructor, 0, 0, 2)
122122
ZEND_ARG_TYPE_INFO(0, path, IS_STRING, 0)
123123
ZEND_ARG_TYPE_INFO(0, values, IS_ARRAY, 0)
124-
ZEND_ARG_TYPE_INFO(0, isXattr, IS_TRUE|IS_FALSE, 0)
125-
ZEND_ARG_TYPE_INFO(0, createPath, IS_TRUE|IS_FALSE, 0)
126-
ZEND_ARG_TYPE_INFO(0, expandMacros, IS_TRUE|IS_FALSE, 0)
124+
ZEND_ARG_TYPE_INFO(0, isXattr, _IS_BOOL, 0)
125+
ZEND_ARG_TYPE_INFO(0, createPath, _IS_BOOL, 0)
126+
ZEND_ARG_TYPE_INFO(0, expandMacros, _IS_BOOL, 0)
127127
ZEND_END_ARG_INFO()
128128

129129
zend_class_entry *pcbc_mutate_array_insert_spec_ce;
@@ -137,9 +137,9 @@ PHP_METHOD(MutateArrayAddUniqueSpec, __construct);
137137
ZEND_BEGIN_ARG_INFO_EX(ai_MutateArrayAddUniqueSpec_constructor, 0, 0, 2)
138138
ZEND_ARG_TYPE_INFO(0, path, IS_STRING, 0)
139139
ZEND_ARG_INFO(0, value)
140-
ZEND_ARG_TYPE_INFO(0, isXattr, IS_TRUE|IS_FALSE, 0)
141-
ZEND_ARG_TYPE_INFO(0, createPath, IS_TRUE|IS_FALSE, 0)
142-
ZEND_ARG_TYPE_INFO(0, expandMacros, IS_TRUE|IS_FALSE, 0)
140+
ZEND_ARG_TYPE_INFO(0, isXattr, _IS_BOOL, 0)
141+
ZEND_ARG_TYPE_INFO(0, createPath, _IS_BOOL, 0)
142+
ZEND_ARG_TYPE_INFO(0, expandMacros, _IS_BOOL, 0)
143143
ZEND_END_ARG_INFO()
144144

145145
zend_class_entry *pcbc_mutate_array_add_unique_spec_ce;
@@ -190,8 +190,8 @@ PHP_METHOD(MutateCounterSpec, __construct);
190190
ZEND_BEGIN_ARG_INFO_EX(ai_MutateCounterSpec_constructor, 0, 0, 2)
191191
ZEND_ARG_TYPE_INFO(0, path, IS_STRING, 0)
192192
ZEND_ARG_TYPE_INFO(0, delta, IS_LONG, 0)
193-
ZEND_ARG_TYPE_INFO(0, isXattr, IS_TRUE|IS_FALSE, 0)
194-
ZEND_ARG_TYPE_INFO(0, createPath, IS_TRUE|IS_FALSE, 0)
193+
ZEND_ARG_TYPE_INFO(0, isXattr, _IS_BOOL, 0)
194+
ZEND_ARG_TYPE_INFO(0, createPath, _IS_BOOL, 0)
195195
ZEND_END_ARG_INFO()
196196

197197
zend_class_entry *pcbc_mutate_counter_spec_ce;

‎src/couchbase/result.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -217,7 +217,7 @@ static const zend_function_entry pcbc_get_result_impl_methods[] = {
217217
ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO(ai_GetReplicaResult_content, IS_OBJECT, 1)
218218
ZEND_END_ARG_INFO()
219219

220-
ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO(ai_GetReplicaResult_isMaster, IS_TRUE|IS_FALSE, 0)
220+
ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO(ai_GetReplicaResult_isMaster, _IS_BOOL, 0)
221221
ZEND_END_ARG_INFO()
222222

223223
zend_class_entry *pcbc_get_replica_result_ce;
@@ -241,7 +241,7 @@ static const zend_function_entry pcbc_get_replica_result_impl_methods[] = {
241241
PHP_FE_END
242242
};
243243

244-
ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO(ai_ExistsResult_exists, IS_TRUE|IS_FALSE, 0)
244+
ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO(ai_ExistsResult_exists, _IS_BOOL, 0)
245245
ZEND_END_ARG_INFO()
246246

247247
zend_class_entry *pcbc_exists_result_ce;

0 commit comments

Comments
 (0)