Skip to content

Commit cbcf155

Browse files
committed
Fix symbol conflict reported on macos
Change-Id: I3ca8baedd903e012ac8404fce5d916c485b8629f Reviewed-on: http://review.couchbase.org/109812 Tested-by: Build Bot <[email protected]> Reviewed-by: Sergey Avseyev <[email protected]>
1 parent 7346b71 commit cbcf155

File tree

2 files changed

+9
-8
lines changed

2 files changed

+9
-8
lines changed

src/couchbase/mutation_state.c

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919

2020
#define LOGARGS(lvl) LCB_LOG_##lvl, NULL, "pcbc/mutation_state", __FILE__, __LINE__
2121

22+
extern zend_class_entry *pcbc_mutation_token_legacy_ce;
2223
zend_class_entry *pcbc_mutation_state_ce;
2324

2425
PHP_METHOD(MutationState, __construct)
@@ -62,20 +63,20 @@ static void pcbc_add_token(pcbc_mutation_state_t *state, pcbc_mutation_token_t *
6263
}
6364

6465
#define ADD_TOKEN_FROM_ZVAL(source) \
65-
if (instanceof_function(Z_OBJCE_P(source), pcbc_mutation_token_ce TSRMLS_CC)) { \
66+
if (instanceof_function(Z_OBJCE_P(source), pcbc_mutation_token_legacy_ce TSRMLS_CC)) { \
6667
pcbc_add_token(state, Z_MUTATION_TOKEN_OBJ_P(source) TSRMLS_CC); \
6768
} else if (instanceof_function(Z_OBJCE_P(source), pcbc_document_ce TSRMLS_CC)) { \
6869
zval *val; \
6970
PCBC_READ_PROPERTY(val, pcbc_document_ce, source, "token", 0); \
7071
if (val && Z_TYPE_P(val) == IS_OBJECT && \
71-
instanceof_function(Z_OBJCE_P(val), pcbc_mutation_token_ce TSRMLS_CC)) { \
72+
instanceof_function(Z_OBJCE_P(val), pcbc_mutation_token_legacy_ce TSRMLS_CC)) { \
7273
pcbc_add_token(state, Z_MUTATION_TOKEN_OBJ_P(val) TSRMLS_CC); \
7374
} \
7475
} else if (instanceof_function(Z_OBJCE_P(source), pcbc_document_fragment_ce TSRMLS_CC)) { \
7576
zval *val; \
7677
PCBC_READ_PROPERTY(val, pcbc_document_fragment_ce, source, "token", 0); \
7778
if (val && Z_TYPE_P(val) == IS_OBJECT && \
78-
instanceof_function(Z_OBJCE_P(val), pcbc_mutation_token_ce TSRMLS_CC)) { \
79+
instanceof_function(Z_OBJCE_P(val), pcbc_mutation_token_legacy_ce TSRMLS_CC)) { \
7980
pcbc_add_token(state, Z_MUTATION_TOKEN_OBJ_P(val) TSRMLS_CC); \
8081
} \
8182
} else { \

src/couchbase/mutation_token.c

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919

2020
#define LOGARGS(lvl) LCB_LOG_##lvl, NULL, "pcbc/mutation_token", __FILE__, __LINE__
2121

22-
zend_class_entry *pcbc_mutation_token_ce;
22+
zend_class_entry *pcbc_mutation_token_legacy_ce;
2323

2424
PHP_METHOD(MutationToken, __construct)
2525
{
@@ -133,7 +133,7 @@ void pcbc_mutation_token_init(zval *return_value, const char *bucket, const lcb_
133133
{
134134
pcbc_mutation_token_t *token;
135135

136-
object_init_ex(return_value, pcbc_mutation_token_ce);
136+
object_init_ex(return_value, pcbc_mutation_token_legacy_ce);
137137
token = Z_MUTATION_TOKEN_OBJ_P(return_value);
138138
token->bucket = estrdup(bucket);
139139
token->mt = *mt;
@@ -198,9 +198,9 @@ PHP_MINIT_FUNCTION(MutationToken)
198198
zend_class_entry ce;
199199

200200
INIT_NS_CLASS_ENTRY(ce, "Couchbase", "MutationTokenLegacy", mutation_token_methods);
201-
pcbc_mutation_token_ce = zend_register_internal_class(&ce TSRMLS_CC);
202-
pcbc_mutation_token_ce->create_object = mutation_token_create_object;
203-
PCBC_CE_DISABLE_SERIALIZATION(pcbc_mutation_token_ce);
201+
pcbc_mutation_token_legacy_ce = zend_register_internal_class(&ce TSRMLS_CC);
202+
pcbc_mutation_token_legacy_ce->create_object = mutation_token_create_object;
203+
PCBC_CE_DISABLE_SERIALIZATION(pcbc_mutation_token_legacy_ce);
204204

205205
memcpy(&pcbc_mutation_token_handlers, zend_get_std_object_handlers(), sizeof(zend_object_handlers));
206206
pcbc_mutation_token_handlers.get_debug_info = mutation_token_get_debug_info;

0 commit comments

Comments
 (0)