Skip to content

Commit 4eeff6f

Browse files
committed
Slightly improve HttpsTestServerLayer
- Send Content-Length header based on the encoded response body - Additionally send "Connection: close" header - Reduce sleep time after starting the server thread
1 parent 06067a2 commit 4eeff6f

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed

src/crate/client/tests.py

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -110,6 +110,7 @@ def setUpMocked(test):
110110
local = '127.0.0.1'
111111
crate_host = "{host}:{port}".format(host=local, port=crate_port)
112112
crate_uri = "http://%s" % crate_host
113+
crate_layer = None
113114

114115

115116
def ensure_cratedb_layer():
@@ -213,7 +214,7 @@ class Location(Base):
213214
test.globs['CrateDialect'] = CrateDialect
214215

215216

216-
class HttpsTestServerLayer(object):
217+
class HttpsTestServerLayer:
217218
PORT = 65534
218219
HOST = "localhost"
219220
CERT_FILE = os.path.abspath(os.path.join(os.path.dirname(__file__),
@@ -238,11 +239,12 @@ class HttpsHandler(BaseHTTPRequestHandler):
238239

239240
def do_GET(self):
240241
self.send_response(200)
241-
self.send_header("Content-Length", len(self.payload))
242+
payload = self.payload.encode('UTF-8')
243+
self.send_header("Content-Length", len(payload))
242244
self.send_header("Content-Type", "application/json; charset=UTF-8")
245+
self.send_header("Connection", "close")
243246
self.end_headers()
244-
self.wfile.write(self.payload.encode('UTF-8'))
245-
return
247+
self.wfile.write(payload)
246248

247249
def __init__(self):
248250
self.server = self.HttpsServer(
@@ -254,7 +256,7 @@ def setUp(self):
254256
thread = threading.Thread(target=self.serve_forever)
255257
thread.daemon = True # quit interpreter when only thread exists
256258
thread.start()
257-
time.sleep(1)
259+
time.sleep(0.5)
258260

259261
def serve_forever(self):
260262
print("listening on", self.HOST, self.PORT)

0 commit comments

Comments
 (0)