Skip to content

Revert: Close urllib3 pool before swapping the server into the "inactive" list #433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 4, 2022

Conversation

amotl
Copy link
Member

@amotl amotl commented Jul 4, 2022

This reverts commit 21509d9.

Apparently, #402 caused some downstream havoc, specifically observable on bad or flaky connection quality to the database. Thanks for reporting, @SStorm!

…ive" list"

This reverts commit 21509d9.

Apparently, this caused some downstream havoc, specifically observable on bad
or flaky connection quality to the database.
@amotl amotl marked this pull request as ready for review July 4, 2022 11:22
@amotl amotl requested review from mfussenegger and seut July 4, 2022 11:22
@amotl amotl merged commit 2e31064 into master Jul 4, 2022
@amotl amotl deleted the amo/fix-inactive-servers branch July 4, 2022 12:26
@amotl amotl mentioned this pull request Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants