-
-
Notifications
You must be signed in to change notification settings - Fork 88
Closed
Labels
bugSomething isn't workingSomething isn't workingcode qualityImprovements to code qualityImprovements to code quality
Milestone
Description
We're not sure whether the following is a good idea:
cursorless/src/processTargets/marks/CursorStage.ts
Lines 21 to 23 in b639e42
return selection.selection.isEmpty | |
? new WeakTarget(parameters) | |
: new TokenTarget(parameters); |
Pros
Cons
The solution
- Rename
WeakTarget
toUntypedRangeTarget
and add a constructor argumenthasExplicitRange
- Rename
isWeak
tohasExplicitScopeType
, but need to negate all references to it as it is the opposite - Check for other references to the term "weak" to make sure we're not missing something
- Introduce
hasExplicitRange
as attribute onTarget
- For eg
ScopeTypeTarget
,hasExplicitScopeType = true
andhasExplicitRange = true
- For each target in spreadsheet, return the proposed type of target as indicated in the Proposed type row
- For each action / modifier in spreadsheet, depending on the value of column Checks for implicit, check either
!hasExplicitRange
or!hasExplicitScopeType
- Add tests for every cell in spreadsheet
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workingcode qualityImprovements to code qualityImprovements to code quality