Skip to content

Commit a8ed29e

Browse files
authored
fix: top nav browsers list scroll (#22094)
1 parent 81f1b42 commit a8ed29e

File tree

3 files changed

+13
-4
lines changed

3 files changed

+13
-4
lines changed

packages/app/src/runner/SpecRunnerHeaderOpenMode.vue

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -98,9 +98,9 @@
9898
>
9999
<!-- disable rule to prevent trailing space from being added to <InlineCodeFragment/> -->
100100
<!-- eslint-disable-next-line vue/singleline-html-element-content-newline -->
101-
<InlineCodeFragment class="text-xs font-medium leading-5">{{ props.gql.configFile }}</InlineCodeFragment>
101+
<InlineCodeFragment class="font-medium text-xs leading-5">{{ props.gql.configFile }}</InlineCodeFragment>
102102
<!-- eslint-disable-next-line vue/singleline-html-element-content-newline -->
103-
<InlineCodeFragment class="text-xs font-medium leading-5">cy.viewport()</InlineCodeFragment>
103+
<InlineCodeFragment class="font-medium text-xs leading-5">cy.viewport()</InlineCodeFragment>
104104
</i18n-t>
105105
<div class="flex justify-center">
106106
<Button

packages/frontend-shared/src/gql-components/HeaderBarContent.cy.tsx

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,8 @@ describe('<HeaderBarContent />', { viewportWidth: 1000, viewportHeight: 750 }, (
1616
.should('be.visible')
1717
.click()
1818

19+
cy.percySnapshot('after browsers open')
20+
1921
cy.contains('Edge Canary')
2022
.should('be.visible')
2123
.closest('[data-cy="top-nav-browser-list-item"]')
@@ -24,15 +26,22 @@ describe('<HeaderBarContent />', { viewportWidth: 1000, viewportHeight: 750 }, (
2426
.should('not.exist')
2527
})
2628

29+
cy.get('[data-cy="top-nav-browser-list-item"]').parent()
30+
.should('have.class', 'overflow-auto')
31+
2732
cy.contains('Version unsupported')
33+
.scrollIntoView()
2834
.should('be.visible')
2935
.closest('[data-cy="top-nav-browser-list-item"]')
3036
.within(() => {
3137
cy.get('[data-cy="unsupported-browser-tooltip-trigger"]')
3238
.should('exist')
39+
.trigger('mouseenter')
3340
})
3441

35-
cy.percySnapshot('after browsers open')
42+
cy.contains('Unsupported browser').should('be.visible')
43+
44+
cy.percySnapshot('unsupported browser tooltip')
3645
}),
3746

3847
it('renders without browser menu by default and other items work', () => {

packages/frontend-shared/src/gql-components/topnav/TopNavList.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
>
3131
<ul
3232
v-if="variant !== 'panel'"
33-
class="flex flex-col"
33+
class="flex flex-col max-h-50vh overflow-auto"
3434
>
3535
<slot />
3636
</ul>

0 commit comments

Comments
 (0)