Clean up #1
Merged
Clean up #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Frederic.Pillon <[email protected]>
|
Board comes with 12mhz Xtal but I was still learning the STM32F subsystem and got 8 & 12mhz config mixed up, have since updated my sources and corrected all astyle errors, correct much more, board now works out of the box with all stm& arduino demos. will do a new pull req on the updates soon. Should i do new board additions as individule pull req's or all as one? |
|
As you merge this PR your PR was automatically updated. About clock config we can update to have 2 variants one with 8 and one with 12 MHz. Is it ok for you? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @darkspr1te
This is the clean up of your variant including Astyle fixes.
About the clock I saw it was a 8MHz ? but you mention a 12MHZ ?