WebPlatform bug ?

[vicb]

While testing angular with IE, I had an issue with WebPlatform.

IIUC the goal of the linked code is to add the name of the custom component as an attribute to all child nodes.. That's because we use strict styling.

The thing is we are not using custom components in Angular, a component can be any node such a vanilla div. How are we supposed to use platform.js in such a case - can it even work ?

Let's find there is a way to make this work then there is an other issue with the code: we try to assign the @Component selector. However the component can be anything ".class, [att]=value, ...". Should we get the element name, the selector would have to be modified to extract the tag name. This probably explains #1189.

@codelogic @jbdeboer please correct me if I'm wrong and add more information - or a fix :)

[Pajn]

This is already true http://andrew.yurisich.com/work/2014/07/16/dont-link-that-line-number/ :)
Fixed link to WebPlatform

[vicb]

@Pajn I think your comments are not relevant here, the issues I described apply to the code you have linked.

[adarshaj]

@vicb That's exactly what @Pajn meant, its relevant to his linked code (to the exact commit + line number), not to the one linked in your OP, it points to master branch, which keeps changing and hence what you linked in your post doesn't make sense anymore now.

[vicb]

oh right, thanks for the link then :)

[vsavkin]

@vicb can we generate a unique id (per component type) and pass it as selector? I don't think we have to use the name of the custom component.

[vicb]

@vsavkin that might be possible, that is something that needs more investigation

[vsavkin]

@vicb I can investigate this issue. I started working on a css shim for transcluding components, and I want to make the two shims compatible.

[vicb]

That would be great.
Some thinking:

• We should add something that would allow selecting the child nodes. This something should be unique for the component class (but shared across component instances),
• As we can attach a shadow DOM to any tag (and not only custom elements) we can not rely on the tag name,
• This could probably be a class or a custom attribute,
• What happen if we add nodes to the component ? There is probably a listener on DOM mutations that add the selector to the nodes, how could we add our custom attribute ?

The following repos are probably useful:

• https://github.com/Polymer/platform-dev
• https://github.com/Polymer/ShadowDOM
• https://github.com/Polymer/CustomElements

[vicb]

From ShadowCSS.js "Note that elements that are dynamically added to a scope must have the scope
selector added to them manually."

This is something that is not currently handled by WebPlatform

[vicb]

@vsavkin I'll skip web_platform_spec on windows. Could you please re-enable them once you've fixed this issue (if #1288 has been merged, otherwise please add a note in this PR so that tests are re-enabled). Thanks.