Skip to content

Commit 9849d74

Browse files
authored
Convert comment_processable_test to use MemoryResourceProvider. (#2324)
Convert comment_processable_test to use MemoryResourceProvider. Add a few tests for @example. Remove a few unnecessary Fake classes.
1 parent 9d014ff commit 9849d74

File tree

5 files changed

+260
-120
lines changed

5 files changed

+260
-120
lines changed

lib/src/model/comment_processable.dart

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -208,6 +208,8 @@ mixin CommentProcessable on Documentable, Warnable, Locatable, SourceCodeMixin {
208208
} else {
209209
var filePath = element.source.fullName.substring(dirPath.length + 1);
210210

211+
// TODO(srawlins): If a file exists at the location without the
212+
// appended 'md' extension, note this.
211213
warn(PackageWarning.missingExampleFile,
212214
message: '${fragmentFile.path}; path listed at $filePath');
213215
}

lib/src/package_meta.dart

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -286,13 +286,9 @@ class _FilePackageMeta extends PubPackageMeta {
286286

287287
_FilePackageMeta(Folder dir, ResourceProvider resourceProvider)
288288
: super(dir, resourceProvider) {
289-
var f = resourceProvider
290-
.getFile(resourceProvider.pathContext.join(dir.path, 'pubspec.yaml'));
291-
if (f.exists) {
292-
_pubspec = loadYaml(f.readAsStringSync());
293-
} else {
294-
_pubspec = <dynamic, dynamic>{};
295-
}
289+
var pubspec = dir.getChildAssumingFile('pubspec.yaml');
290+
assert(pubspec.exists);
291+
_pubspec = loadYaml(pubspec.readAsStringSync());
296292
}
297293

298294
bool _setHostedAt = false;

0 commit comments

Comments
 (0)