From edb3d17ade66402b4574fd9a7ddbab450ee85a72 Mon Sep 17 00:00:00 2001 From: Janice Collins Date: Tue, 7 Apr 2020 12:26:29 -0700 Subject: [PATCH] Fix accidental reentrance on TopLevelVariables in rare case --- lib/src/model/package_graph.dart | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/src/model/package_graph.dart b/lib/src/model/package_graph.dart index cc8d51db20..a4f60d2629 100644 --- a/lib/src/model/package_graph.dart +++ b/lib/src/model/package_graph.dart @@ -105,7 +105,7 @@ class PackageGraph { yield d.precacheLocalDocs(); // TopLevelVariables get their documentation from getters and setters, // so should be precached if either has a template. - if (m is TopLevelVariable) { + if (m is TopLevelVariable && !precachedElements.contains(m)) { precachedElements.add(m); yield m.precacheLocalDocs(); }