Skip to content

Revise "Private Named Parameters". #4475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 23, 2025
Merged

Revise "Private Named Parameters". #4475

merged 3 commits into from
Jul 23, 2025
+39 −16

Conversation

munificent
Copy link
Member

I really like the text you proposed on the issue, so here it is. :)

Fix #4471.

@munificent munificent requested a review from leafpetersen July 21, 2025 23:48
@munificent munificent changed the title Revise the motivation section for "Private Named Parameters". Revise "Private Named Parameters". Jul 22, 2025
leafpetersen
leafpetersen reviewed Jul 22, 2025
View reviewed changes
leafpetersen
leafpetersen approved these changes Jul 22, 2025
View reviewed changes
Copy link
Member

@leafpetersen leafpetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@munificent munificent merged commit aca410c into main Jul 23, 2025
4 checks passed
@munificent munificent deleted the private-named-params-revise-motivation branch July 23, 2025 18:21
@munificent munificent mentioned this pull request Jul 23, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leafpetersen leafpetersen leafpetersen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Private named parameters: feature spec motivation issues
2 participants
@munificent @leafpetersen