Skip to content

Commit 7a1d6a9

Browse files
committed
[benchmark] run_vm_tests with kernel-service.dart.snapshot.
This change tests that run_vm_tests runs correctly when provided with the kernel service snapshot, which is needed to run benchmarks like UseDartApi. Test building the kernel-service.dart.snapshot. Change-Id: I1cb750a16e32daba2eee46e245cc7d4e7d230165 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151395 Reviewed-by: Alexander Aprelev <[email protected]>
1 parent 060d948 commit 7a1d6a9

File tree

2 files changed

+24
-14
lines changed

2 files changed

+24
-14
lines changed

tools/bots/test_matrix.json

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3323,7 +3323,8 @@
33233323
"--mode=release",
33243324
"--arch=ia32",
33253325
"create_sdk",
3326-
"runtime"
3326+
"runtime",
3327+
"kernel-service.dart.snapshot"
33273328
]
33283329
},
33293330
{
@@ -3356,7 +3357,8 @@
33563357
"create_sdk",
33573358
"runtime",
33583359
"gen_snapshot",
3359-
"dart_precompiled_runtime"
3360+
"dart_precompiled_runtime",
3361+
"kernel-service.dart.snapshot"
33603362
]
33613363
},
33623364
{

tools/bots/try_benchmarks.sh

Lines changed: 20 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,7 @@ for command; do
7777
# NOTE: These are duplicated in tools/bots/test_matrix.json, keep in sync.
7878
./tools/build.py --mode=release --arch=ia32 create_sdk
7979
./tools/build.py --mode=release --arch=ia32 runtime
80+
./tools/build.py --mode=release --arch=ia32 kernel-service.dart.snapshot
8081
elif [ "$command" = linux-ia32-archive ]; then
8182
strip -w \
8283
-K 'kDartVmSnapshotData' \
@@ -151,6 +152,7 @@ for command; do
151152
out/ReleaseIA32/dart \
152153
out/ReleaseIA32/gen_snapshot \
153154
out/ReleaseIA32/gen_kernel_bytecode.dill \
155+
out/ReleaseIA32/kernel-service.dart.snapshot \
154156
out/ReleaseIA32/run_vm_tests \
155157
sdk \
156158
samples-dev/swarm \
@@ -180,12 +182,14 @@ EOF
180182
out/ReleaseIA32/dart pkg/front_end/tool/fasta_perf.dart kernel_gen_e2e hello.dart
181183
out/ReleaseIA32/dart pkg/front_end/tool/fasta_perf.dart scan hello.dart
182184
out/ReleaseIA32/dart --print_metrics pkg/analyzer_cli/bin/analyzer.dart --dart-sdk=sdk hello.dart
183-
out/ReleaseIA32/run_vm_tests InitialRSS
184-
out/ReleaseIA32/run_vm_tests --sound-null-safety --enable-experiment=non-nullable InitialRSS
185-
out/ReleaseIA32/run_vm_tests GenKernelKernelLoadKernel
186-
out/ReleaseIA32/run_vm_tests --sound-null-safety --enable-experiment=non-nullable GenKernelKernelLoadKernel
187-
out/ReleaseIA32/run_vm_tests KernelServiceCompileAll
188-
out/ReleaseIA32/run_vm_tests --sound-null-safety --enable-experiment=non-nullable KernelServiceCompileAll
185+
out/ReleaseIA32/run_vm_tests --dfe=out/ReleaseIA32/kernel-service.dart.snapshot InitialRSS
186+
out/ReleaseIA32/run_vm_tests --dfe=out/ReleaseIA32/kernel-service.dart.snapshot --sound-null-safety --enable-experiment=non-nullable InitialRSS
187+
out/ReleaseIA32/run_vm_tests --dfe=out/ReleaseIA32/kernel-service.dart.snapshot GenKernelKernelLoadKernel
188+
out/ReleaseIA32/run_vm_tests --dfe=out/ReleaseIA32/kernel-service.dart.snapshot --sound-null-safety --enable-experiment=non-nullable GenKernelKernelLoadKernel
189+
out/ReleaseIA32/run_vm_tests --dfe=out/ReleaseIA32/kernel-service.dart.snapshot KernelServiceCompileAll
190+
out/ReleaseIA32/run_vm_tests --dfe=out/ReleaseIA32/kernel-service.dart.snapshot --sound-null-safety --enable-experiment=non-nullable KernelServiceCompileAll
191+
out/ReleaseIA32/run_vm_tests --dfe=out/ReleaseIA32/kernel-service.dart.snapshot UseDartApi
192+
out/ReleaseIA32/run_vm_tests --dfe=out/ReleaseIA32/kernel-service.dart.snapshot --sound-null-safety --enable-experiment=non-nullable UseDartApi
189193
out/ReleaseIA32/dart --profile-period=10000 --packages=.packages benchmarks/Example/dart2/Example.dart
190194
out/ReleaseIA32/dart --sound-null-safety --enable-experiment=non-nullable --profile-period=10000 --packages=.packages benchmarks/Example/dart/Example.dart
191195
out/ReleaseIA32/dart benchmarks/FfiBoringssl/dart2/FfiBoringssl.dart
@@ -204,6 +208,7 @@ EOF
204208
./tools/build.py --mode=release --arch=x64 runtime
205209
./tools/build.py --mode=release --arch=x64 gen_snapshot
206210
./tools/build.py --mode=release --arch=x64 dart_precompiled_runtime
211+
./tools/build.py --mode=release --arch=x64 kernel-service.dart.snapshot
207212
elif [ "$command" = linux-x64-archive ]; then
208213
strip -w \
209214
-K 'kDartVmSnapshotData' \
@@ -296,6 +301,7 @@ EOF
296301
out/ReleaseX64/dart \
297302
out/ReleaseX64/gen_snapshot \
298303
out/ReleaseX64/gen_kernel_bytecode.dill \
304+
out/ReleaseX64/kernel-service.dart.snapshot \
299305
out/ReleaseX64/run_vm_tests \
300306
third_party/d8/linux/x64 \
301307
third_party/firefox_jsshell/linux/ \
@@ -354,12 +360,14 @@ EOF
354360
out/ReleaseX64/dart --background-compilation=false --snapshot-kind=app-jit --snapshot=pkg/front_end/tool/incremental_perf.dart.appjit pkg/front_end/tool/incremental_perf.dart --target=vm --sdk-summary=out/ReleaseX64/vm_platform_strong.dill --sdk-library-specification=sdk/lib/libraries.json pkg/compiler/lib/src/dart2js.dart appjit_train_edits.json
355361
out/ReleaseX64/dart --background-compilation=false pkg/front_end/tool/incremental_perf.dart.appjit --target=vm --sdk-summary=out/ReleaseX64/vm_platform_strong.dill --sdk-library-specification=sdk/lib/libraries.json pkg/front_end/benchmarks/ikg/hello.dart pkg/front_end/benchmarks/ikg/hello.edits.json
356362
out/ReleaseX64/dart --packages=.packages pkg/kernel/test/binary_bench.dart --golem AstFromBinaryLazy out/ReleaseX64/vm_platform_strong.dill
357-
out/ReleaseX64/run_vm_tests InitialRSS
358-
out/ReleaseX64/run_vm_tests --sound-null-safety --enable-experiment=non-nullable InitialRSS
359-
out/ReleaseX64/run_vm_tests GenKernelKernelLoadKernel
360-
out/ReleaseX64/run_vm_tests --sound-null-safety --enable-experiment=non-nullable GenKernelKernelLoadKernel
361-
out/ReleaseX64/run_vm_tests KernelServiceCompileAll
362-
out/ReleaseX64/run_vm_tests --sound-null-safety --enable-experiment=non-nullable KernelServiceCompileAll
363+
out/ReleaseX64/run_vm_tests --dfe=out/ReleaseX64/kernel-service.dart.snapshot InitialRSS
364+
out/ReleaseX64/run_vm_tests --dfe=out/ReleaseX64/kernel-service.dart.snapshot --sound-null-safety --enable-experiment=non-nullable InitialRSS
365+
out/ReleaseX64/run_vm_tests --dfe=out/ReleaseX64/kernel-service.dart.snapshot GenKernelKernelLoadKernel
366+
out/ReleaseX64/run_vm_tests --dfe=out/ReleaseX64/kernel-service.dart.snapshot --sound-null-safety --enable-experiment=non-nullable GenKernelKernelLoadKernel
367+
out/ReleaseX64/run_vm_tests --dfe=out/ReleaseX64/kernel-service.dart.snapshot KernelServiceCompileAll
368+
out/ReleaseX64/run_vm_tests --dfe=out/ReleaseX64/kernel-service.dart.snapshot --sound-null-safety --enable-experiment=non-nullable KernelServiceCompileAll
369+
out/ReleaseX64/run_vm_tests --dfe=out/ReleaseX64/kernel-service.dart.snapshot UseDartApi
370+
out/ReleaseX64/run_vm_tests --dfe=out/ReleaseX64/kernel-service.dart.snapshot --sound-null-safety --enable-experiment=non-nullable UseDartApi
363371
out/ReleaseX64/dart --profile-period=10000 --packages=.packages benchmarks/Example/dart2/Example.dart
364372
out/ReleaseX64/dart --sound-null-safety --enable-experiment=non-nullable --profile-period=10000 --packages=.packages benchmarks/Example/dart/Example.dart
365373
cd ..

0 commit comments

Comments
 (0)