Skip to content

Commit bda4994

Browse files
srawlinscommit-bot@chromium.org
authored andcommitted
Analyzer: Finish using ///-style comments.
This ignores the Lint on a few files where it is undesired. Change-Id: I5e4244607da0ef60678cebb89a433e44cb1e753f Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/153180 Reviewed-by: Brian Wilkerson <[email protected]> Reviewed-by: Konstantin Shcheglov <[email protected]> Commit-Queue: Samuel Rawlins <[email protected]>
1 parent 42d2996 commit bda4994

File tree

6 files changed

+248
-326
lines changed

6 files changed

+248
-326
lines changed

pkg/analyzer/analysis_options.yaml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -11,12 +11,6 @@ analyzer:
1111
omit_local_variable_types: ignore
1212
# There are currently 3360 violations in lib/.
1313
prefer_single_quotes: ignore
14-
# Ignoring "style" lint rules from pedantic for now. There are pre-existing
15-
# violations that need to be cleaned up. Each one can be cleaned up and
16-
# enabled according to the value provided.
17-
# TODO(srawlins): At the time of writing, 500 violations in lib/. The fix
18-
# is mechanical, via `dartfmt --fix-doc-comments`.
19-
slash_for_doc_comments: ignore
2014
# There are currently 2000 violations in lib/.
2115
unnecessary_this: ignore
2216

pkg/analyzer/lib/src/dart/error/ffi_code.dart

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,10 @@ import 'package:analyzer/error/error.dart';
66
import 'package:analyzer/src/error/analyzer_error_code.dart';
77
import 'package:meta/meta.dart';
88

9+
// It is hard to visually separate each code's _doc comment_ from its published
10+
// _documentation comment_ when each is written as an end-of-line comment.
11+
// ignore_for_file: slash_for_doc_comments
12+
913
/// The diagnostic codes associated with `dart:ffi`.
1014
class FfiCode extends AnalyzerErrorCode {
1115
/**

pkg/analyzer/lib/src/dart/error/hint_codes.dart

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,10 @@
55
import 'package:analyzer/error/error.dart';
66
import 'package:analyzer/src/error/analyzer_error_code.dart';
77

8+
// It is hard to visually separate each code's _doc comment_ from its published
9+
// _documentation comment_ when each is written as an end-of-line comment.
10+
// ignore_for_file: slash_for_doc_comments
11+
812
/**
913
* The hints and coding recommendations for best practices which are not
1014
* mentioned in the Dart Language Specification.

pkg/analyzer/lib/src/dart/error/syntactic_errors.dart

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,10 @@
22
// for details. All rights reserved. Use of this source code is governed by a
33
// BSD-style license that can be found in the LICENSE file.
44

5+
// It is hard to visually separate each code's _doc comment_ from its published
6+
// _documentation comment_ when each is written as an end-of-line comment.
7+
// ignore_for_file: slash_for_doc_comments
8+
59
/**
610
* The errors produced during syntactic analysis (scanning and parsing).
711
*/

pkg/analyzer/lib/src/dart/error/todo_codes.dart

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,10 @@
44

55
import 'package:analyzer/error/error.dart';
66

7+
// It is hard to visually separate each code's _doc comment_ from its published
8+
// _documentation comment_ when each is written as an end-of-line comment.
9+
// ignore_for_file: slash_for_doc_comments
10+
711
/**
812
* The error code indicating a marker in code for work that needs to be finished
913
* or revisited.

0 commit comments

Comments
 (0)