Skip to content

Commit 649e5f6

Browse files
deadlycoconutsdeadlycoconuts
authored
fix(xp-treatment): Add field tags to poller configs and make XP plugin pass poller configs (caraml-dev#88)
* Add field tags to poller configs * Add poller config to plugin * Update message queue config with json tags * Update xp plugin to use message queue config from manager instead of xp management * Reorder imports * Change poller interval field to int * Reorder imports * Reorder imports * Refactor poller into a service
1 parent 397e59b commit 649e5f6

File tree

12 files changed

+66
-82
lines changed

12 files changed

+66
-82
lines changed

‎common/messagequeue/config.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,10 @@ const (
1212

1313
type MessageQueueConfig struct {
1414
// The type of Message Queue for event updates
15-
Kind MessageQueueKind `default:""`
15+
Kind MessageQueueKind `json:"kind" default:""`
1616

1717
// PubSubConfig captures the config related to publishing and subscribing to a PubSub Message Queue
18-
PubSubConfig *PubSubConfig
18+
PubSubConfig *PubSubConfig `json:"pub_sub_config"`
1919
}
2020

2121
type PubSubConfig struct {

‎plugins/turing/config/config.go

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ import (
66

77
"github.com/caraml-dev/mlp/api/pkg/instrumentation/newrelic"
88
"github.com/caraml-dev/mlp/api/pkg/instrumentation/sentry"
9+
common_mq_config "github.com/caraml-dev/xp/common/messagequeue"
910
"github.com/caraml-dev/xp/treatment-service/config"
1011
"github.com/go-playground/validator/v10"
1112
)
@@ -46,14 +47,16 @@ type TreatmentServicePluginConfig struct {
4647
Port int `json:"port" default:"8080"`
4748
PubSubTimeoutSeconds int `json:"pub_sub_timeout_seconds" validate:"required"`
4849

49-
AssignedTreatmentLogger config.AssignedTreatmentLoggerConfig `json:"assigned_treatment_logger"`
50-
DebugConfig config.DebugConfig `json:"debug_config"`
51-
DeploymentConfig config.DeploymentConfig `json:"deployment_config"`
52-
ManagementService config.ManagementServiceConfig `json:"management_service"`
53-
MonitoringConfig config.Monitoring `json:"monitoring_config"`
54-
SwaggerConfig config.SwaggerConfig `json:"swagger_config"`
55-
NewRelicConfig newrelic.Config `json:"new_relic_config"`
56-
SentryConfig sentry.Config `json:"sentry_config"`
50+
AssignedTreatmentLogger config.AssignedTreatmentLoggerConfig `json:"assigned_treatment_logger"`
51+
DebugConfig config.DebugConfig `json:"debug_config"`
52+
DeploymentConfig config.DeploymentConfig `json:"deployment_config"`
53+
MessageQueueConfig common_mq_config.MessageQueueConfig `json:"message_queue_config"`
54+
ManagementService config.ManagementServiceConfig `json:"management_service"`
55+
MonitoringConfig config.Monitoring `json:"monitoring_config"`
56+
SwaggerConfig config.SwaggerConfig `json:"swagger_config"`
57+
NewRelicConfig newrelic.Config `json:"new_relic_config"`
58+
SentryConfig sentry.Config `json:"sentry_config"`
59+
ManagementServicePollerConfig config.ManagementServicePollerConfig `json:"management_service_poller_config"`
5760
}
5861

5962
type Variable struct {

‎plugins/turing/manager/experiment_manager.go

Lines changed: 13 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ import (
1414

1515
xpclient "github.com/caraml-dev/xp/clients/management"
1616
"github.com/caraml-dev/xp/common/api/schema"
17-
common_mq_config "github.com/caraml-dev/xp/common/messagequeue"
1817
_config "github.com/caraml-dev/xp/plugins/turing/config"
1918
"github.com/caraml-dev/xp/treatment-service/config"
2019
"github.com/go-playground/validator/v10"
@@ -142,37 +141,20 @@ func (em *experimentManager) MakeTreatmentServicePluginConfig(
142141
projectID int,
143142
) (*config.Config, error) {
144143
pluginConfig := &config.Config{
145-
Port: em.TreatmentServicePluginConfig.Port,
146-
ProjectIds: []string{strconv.Itoa(projectID)},
147-
AssignedTreatmentLogger: em.TreatmentServicePluginConfig.AssignedTreatmentLogger,
148-
DebugConfig: em.TreatmentServicePluginConfig.DebugConfig,
149-
DeploymentConfig: em.TreatmentServicePluginConfig.DeploymentConfig,
150-
ManagementService: em.TreatmentServicePluginConfig.ManagementService,
151-
MonitoringConfig: em.TreatmentServicePluginConfig.MonitoringConfig,
152-
SwaggerConfig: em.TreatmentServicePluginConfig.SwaggerConfig,
153-
NewRelicConfig: em.TreatmentServicePluginConfig.NewRelicConfig,
154-
SentryConfig: em.TreatmentServicePluginConfig.SentryConfig,
155-
SegmenterConfig: *treatmentServiceConfig.SegmenterConfig,
156-
}
157-
messageQueueKind := *treatmentServiceConfig.MessageQueueConfig.Kind
158-
switch messageQueueKind {
159-
case schema.MessageQueueKindPubsub:
160-
pluginConfig.MessageQueueConfig = common_mq_config.MessageQueueConfig{
161-
Kind: "pubsub",
162-
PubSubConfig: &common_mq_config.PubSubConfig{
163-
Project: *treatmentServiceConfig.MessageQueueConfig.PubSub.Project,
164-
TopicName: *treatmentServiceConfig.MessageQueueConfig.PubSub.TopicName,
165-
PubSubTimeoutSeconds: em.TreatmentServicePluginConfig.PubSubTimeoutSeconds,
166-
},
167-
}
168-
case schema.MessageQueueKindNoop:
169-
pluginConfig.MessageQueueConfig = common_mq_config.MessageQueueConfig{
170-
Kind: "",
171-
}
172-
default:
173-
return nil, fmt.Errorf("invalid message queue kind (%s) was provided", messageQueueKind)
144+
Port: em.TreatmentServicePluginConfig.Port,
145+
ProjectIds: []string{strconv.Itoa(projectID)},
146+
AssignedTreatmentLogger: em.TreatmentServicePluginConfig.AssignedTreatmentLogger,
147+
DebugConfig: em.TreatmentServicePluginConfig.DebugConfig,
148+
DeploymentConfig: em.TreatmentServicePluginConfig.DeploymentConfig,
149+
MessageQueueConfig: em.TreatmentServicePluginConfig.MessageQueueConfig,
150+
ManagementService: em.TreatmentServicePluginConfig.ManagementService,
151+
MonitoringConfig: em.TreatmentServicePluginConfig.MonitoringConfig,
152+
SwaggerConfig: em.TreatmentServicePluginConfig.SwaggerConfig,
153+
NewRelicConfig: em.TreatmentServicePluginConfig.NewRelicConfig,
154+
SentryConfig: em.TreatmentServicePluginConfig.SentryConfig,
155+
SegmenterConfig: *treatmentServiceConfig.SegmenterConfig,
156+
ManagementServicePollerConfig: em.TreatmentServicePluginConfig.ManagementServicePollerConfig,
174157
}
175-
176158
return pluginConfig, nil
177159
}
178160

‎plugins/turing/manager/experiment_manager_test.go

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,14 @@ func TestNewExperimentManager(t *testing.T) {
6262
"environment_type": "dev",
6363
"max_go_routines": 200
6464
},
65+
"message_queue_config": {
66+
"kind": "dev",
67+
"pub_sub_config": {
68+
"project":"dev",
69+
"topic_name":"xp-update",
70+
"pub_sub_timeout_seconds": 30
71+
}
72+
},
6573
"management_service": {
6674
"authorization_enabled": true,
6775
"url": "http://xp-management.global.io/api/xp/v1"

‎plugins/turing/runner/experiment_runner.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -257,6 +257,9 @@ func (er *experimentRunner) startBackgroundServices(
257257
}
258258
}()
259259
}
260+
if er.appContext.PollerService != nil {
261+
er.appContext.PollerService.Start()
262+
}
260263
}
261264

262265
func (er *experimentRunner) getRequestParams(

‎treatment-service/appcontext/appcontext.go

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ type AppContext struct {
2424

2525
AssignedTreatmentLogger *monitoring.AssignedTreatmentLogger
2626
LocalStorage *models.LocalStorage
27+
PollerService *services.PollerService
2728
}
2829

2930
func NewAppContext(cfg *config.Config) (*AppContext, error) {
@@ -122,6 +123,11 @@ func NewAppContext(cfg *config.Config) (*AppContext, error) {
122123
return nil, err
123124
}
124125

126+
var pollerService *services.PollerService
127+
if cfg.ManagementServicePollerConfig.Enabled {
128+
pollerService = services.NewPollerService(cfg.ManagementServicePollerConfig, localStorage)
129+
}
130+
125131
appContext := &AppContext{
126132
ExperimentService: experimentSvc,
127133
MetricService: metricService,
@@ -131,6 +137,7 @@ func NewAppContext(cfg *config.Config) (*AppContext, error) {
131137
AssignedTreatmentLogger: logger,
132138
MessageQueueService: messageQueueService,
133139
LocalStorage: localStorage,
140+
PollerService: pollerService,
134141
}
135142

136143
return appContext, nil

‎treatment-service/config/config.go

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ package config
33
import (
44
"fmt"
55
"strconv"
6-
"time"
76

87
"github.com/caraml-dev/mlp/api/pkg/instrumentation/newrelic"
98
"github.com/caraml-dev/mlp/api/pkg/instrumentation/sentry"
@@ -96,8 +95,8 @@ type ManagementServiceConfig struct {
9695
}
9796

9897
type ManagementServicePollerConfig struct {
99-
Enabled bool `default:"false"`
100-
PollInterval time.Duration `default:"30s"`
98+
Enabled bool `json:"enabled" default:"false"`
99+
PollIntervalSeconds int `json:"poll_interval" default:"30"`
101100
}
102101

103102
func (c *Config) GetProjectIds() []models.ProjectId {

‎treatment-service/config/config_test.go

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ package config
22

33
import (
44
"testing"
5-
"time"
65

76
"github.com/caraml-dev/mlp/api/pkg/instrumentation/newrelic"
87
"github.com/caraml-dev/mlp/api/pkg/instrumentation/sentry"
@@ -66,8 +65,8 @@ func TestDefaultConfigs(t *testing.T) {
6665
SentryConfig: sentry.Config{Enabled: false, Labels: emptyStringMap},
6766
SegmenterConfig: make(map[string]interface{}),
6867
ManagementServicePollerConfig: ManagementServicePollerConfig{
69-
Enabled: false,
70-
PollInterval: 30 * time.Second,
68+
Enabled: false,
69+
PollIntervalSeconds: 30,
7170
},
7271
}
7372
cfg, err := Load()
@@ -133,8 +132,8 @@ func TestLoadMultipleConfigs(t *testing.T) {
133132
SentryConfig: sentry.Config{Enabled: true, DSN: "my.amazing.sentry.dsn", Labels: map[string]string{"app": "xp-treatment-service"}},
134133
SegmenterConfig: map[string]interface{}{"s2_ids": map[string]interface{}{"mins2celllevel": 9, "maxs2celllevel": 15}},
135134
ManagementServicePollerConfig: ManagementServicePollerConfig{
136-
Enabled: false,
137-
PollInterval: 30 * time.Second,
135+
Enabled: false,
136+
PollIntervalSeconds: 30,
138137
},
139138
}
140139

‎treatment-service/go.mod

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ require (
1414
github.com/deepmap/oapi-codegen v1.11.0
1515
github.com/getkin/kin-openapi v0.94.0
1616
github.com/go-chi/chi/v5 v5.0.7
17-
github.com/go-playground/validator/v10 v10.11.1
1817
github.com/golang-collections/collections v0.0.0-20130729185459-604e922904d3
1918
github.com/golang/geo v0.0.0-20210211234256-740aa86cb551
2019
github.com/google/go-cmp v0.6.0
@@ -104,8 +103,6 @@ require (
104103
github.com/go-openapi/jsonpointer v0.19.6 // indirect
105104
github.com/go-openapi/jsonreference v0.20.2 // indirect
106105
github.com/go-openapi/swag v0.22.3 // indirect
107-
github.com/go-playground/locales v0.14.0 // indirect
108-
github.com/go-playground/universal-translator v0.18.0 // indirect
109106
github.com/go-viper/mapstructure/v2 v2.0.0 // indirect
110107
github.com/goccy/go-json v0.9.11 // indirect
111108
github.com/gofrs/flock v0.8.1 // indirect
@@ -139,7 +136,6 @@ require (
139136
github.com/klauspost/asmfmt v1.3.2 // indirect
140137
github.com/klauspost/compress v1.17.4 // indirect
141138
github.com/klauspost/cpuid/v2 v2.0.9 // indirect
142-
github.com/leodido/go-urn v1.2.1 // indirect
143139
github.com/lufia/plan9stats v0.0.0-20211012122336-39d0f177ccd0 // indirect
144140
github.com/magiconair/properties v1.8.7 // indirect
145141
github.com/mailru/easyjson v0.7.7 // indirect

‎treatment-service/go.sum

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -333,18 +333,13 @@ github.com/go-openapi/swag v0.19.5/go.mod h1:POnQmlKehdgb5mhVOsnJFsivZCEZ/vjK9gh
333333
github.com/go-openapi/swag v0.21.1/go.mod h1:QYRuS/SOXUCsnplDa677K7+DxSOj6IPNl/eQntq43wQ=
334334
github.com/go-openapi/swag v0.22.3 h1:yMBqmnQ0gyZvEb/+KzuWZOXgllrXT4SADYbvDaXHv/g=
335335
github.com/go-openapi/swag v0.22.3/go.mod h1:UzaqsxGiab7freDnrUUra0MwWfN/q7tE4j+VcZ0yl14=
336-
github.com/go-playground/assert/v2 v2.0.1 h1:MsBgLAaY856+nPRTKrp3/OZK38U/wa0CcBYNjji3q3A=
337336
github.com/go-playground/assert/v2 v2.0.1/go.mod h1:VDjEfimB/XKnb+ZQfWdccd7VUvScMdVu0Titje2rxJ4=
338337
github.com/go-playground/locales v0.13.0/go.mod h1:taPMhCMXrRLJO55olJkUXHZBHCxTMfnGwq/HNwmWNS8=
339-
github.com/go-playground/locales v0.14.0 h1:u50s323jtVGugKlcYeyzC0etD1HifMjqmJqb8WugfUU=
340338
github.com/go-playground/locales v0.14.0/go.mod h1:sawfccIbzZTqEDETgFXqTho0QybSa7l++s0DH+LDiLs=
341339
github.com/go-playground/universal-translator v0.17.0/go.mod h1:UkSxE5sNxxRwHyU+Scu5vgOQjsIJAF8j9muTVoKLVtA=
342-
github.com/go-playground/universal-translator v0.18.0 h1:82dyy6p4OuJq4/CByFNOn/jYrnRPArHwAcmLoJZxyho=
343340
github.com/go-playground/universal-translator v0.18.0/go.mod h1:UvRDBj+xPUEGrFYl+lu/H90nyDXpg0fqeB/AQUGNTVA=
344341
github.com/go-playground/validator/v10 v10.4.1/go.mod h1:nlOn6nFhuKACm19sB/8EGNn9GlaMV7XkbRSipzJ0Ii4=
345342
github.com/go-playground/validator/v10 v10.11.0/go.mod h1:i+3WkQ1FvaUjjxh1kSvIA4dMGDBiPU55YFDl0WbKdWU=
346-
github.com/go-playground/validator/v10 v10.11.1 h1:prmOlTVv+YjZjmRmNSF3VmspqJIxJWXmqUsHwfTRRkQ=
347-
github.com/go-playground/validator/v10 v10.11.1/go.mod h1:i+3WkQ1FvaUjjxh1kSvIA4dMGDBiPU55YFDl0WbKdWU=
348343
github.com/go-sql-driver/mysql v1.3.0 h1:pgwjLi/dvffoP9aabwkT3AKpXQM93QARkjFhDDqC1UE=
349344
github.com/go-sql-driver/mysql v1.3.0/go.mod h1:zAC/RDZ24gD3HViQzih4MyKcchzm+sOG5ZlKdlhCg5w=
350345
github.com/go-stack/stack v1.8.0/go.mod h1:v0f6uXyyMGvRgIKkXu+yp6POWl0qKG85gN/melR3HDY=
@@ -604,7 +599,6 @@ github.com/kr/text v0.2.0/go.mod h1:eLer722TekiGuMkidMxC/pM04lWEeraHUUmBw8l2grE=
604599
github.com/labstack/echo/v4 v4.7.2/go.mod h1:xkCDAdFCIf8jsFQ5NnbK7oqaF/yU1A1X20Ltm0OvSks=
605600
github.com/labstack/gommon v0.3.1/go.mod h1:uW6kP17uPlLJsD3ijUYn3/M5bAxtlZhMI6m3MFxTMTM=
606601
github.com/leodido/go-urn v1.2.0/go.mod h1:+8+nEpDfqqsY+g338gtMEUOtuK+4dEMhiQEgxpxOKII=
607-
github.com/leodido/go-urn v1.2.1 h1:BqpAaACuzVSgi/VLzGZIobT2z4v53pjosyNd9Yv6n/w=
608602
github.com/leodido/go-urn v1.2.1/go.mod h1:zt4jvISO2HfUBqxjfIshjdMTYS56ZS/qv49ictyFfxY=
609603
github.com/lestrrat-go/backoff/v2 v2.0.8/go.mod h1:rHP/q/r9aT27n24JQLa7JhSQZCKBBOiM/uP402WwN8Y=
610604
github.com/lestrrat-go/blackmagic v1.0.0/go.mod h1:TNgH//0vYSs8VXDCfkZLgIrVTTXQELZffUV0tz3MtdQ=

0 commit comments

Comments
 (0)