Skip to content

Commit 2c24fdb

Browse files
SlouchyButtonduzda
andcommitted
Make readme more coherent with path examples, fix typos
Suggestions from code review Co-authored-by: David Hanina <[email protected]>
1 parent 425af32 commit 2c24fdb

File tree

1 file changed

+9
-5
lines changed

1 file changed

+9
-5
lines changed

README.md

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,16 @@
33
## Requires
44

55
### BuildRequires
6+
- make
67
- m4
78
- docbook-utils
89
- help2man
910
- elinks (pretty README.rpm-dist)
1011
- postgresql-server (detect current version)
1112

13+
Installable on Fedora with\
14+
`sudo dnf install m4 docbook-utils help2man elinks postgresql-server`
15+
1216
### Requires
1317
- coreutils
1418

@@ -22,7 +26,7 @@
2226

2327
## Usage
2428
This script is used as a wrapper around PostgreSQL initialization and upgrade
25-
commands. It also parses init system service files and/or enviroment files to
29+
commands. It also parses init system service files and/or environment files to
2630
correctly find datadir based on current system.
2731

2832
### Initialization
@@ -34,7 +38,7 @@ use `./postgresql-setup --upgrade`.
3438

3539
If your distribution doesn't include this
3640
script with PostgreSQL and you are using this on your own, please update
37-
`etc/postgresql-setup/upgrade/postgresql.conf` to reflect your setup.
41+
`./etc/postgresql-setup/upgrade/postgresql.conf` to reflect your setup.
3842

3943
### Running without systemd/init system
4044
Your setup might not include systemd as the init system or include any
@@ -46,15 +50,15 @@ service file in preconfigured path directly. By default the path is
4650
If there is no systemd service file, or for whatever reason the script is unable
4751
to find valid PostgreSQL data directory, you can still provide PostgreSQL data
4852
directory path manually by using `--datadir` argument. For example when
49-
initializing new data directory use `./postgresql-setup --initdb --datadir=/my/path`.
53+
initializing new data directory use `postgresql-setup --initdb --datadir=/my/path`.
5054

5155
This feature is most beneficial when using this script inside container images,
5256
as it gives you the most control with least dependencies.
5357

5458
## Maintainer notes
55-
Be careful about paths. Your might need to tweak paths either in configure
59+
Be careful about paths. You might need to tweak paths either in the configure
5660
files, or in code based on your environment.
57-
- Line 49 of `/bin/postgresql-setup` in function `builddir_source ()` has to
61+
- Line 49 of `./bin/postgresql-setup.in` in function `builddir_source ()` has to
5862
be changed to location of your project otherwise you won't be able to run your
5963
build without full installation into system paths
6064
- For example line should be `. "/postgresql-setup/$file"` if your

0 commit comments

Comments
 (0)