f pep

Author: Boris Pleshakov

rest_framework_json_api/renderers.py

@@ -13,7 +13,7 @@
 from rest_framework.relations import PKOnlyObject
 from rest_framework.serializers import BaseSerializer, ListSerializer, Serializer
 from rest_framework.settings import api_settings
-from .settings import json_api_settings, RELATIONS_RENDERING_STRATEGY, ATTRIBUTE_RENDERING_STRATEGY
+from .settings import json_api_settings
 
 import rest_framework_json_api
 from rest_framework_json_api import utils

rest_framework_json_api/serializers.py

@@ -15,7 +15,7 @@
     get_resource_type_from_serializer
 )
 
-from rest_framework_json_api.settings import json_api_settings, RELATIONS_RENDERING_STRATEGY
+from rest_framework_json_api.settings import json_api_settings
 
 
 class ResourceIdentifierObjectSerializer(BaseSerializer):

rest_framework_json_api/settings.py

@@ -10,9 +10,6 @@
 
 JSON_API_SETTINGS_PREFIX = 'JSON_API_'
 
-RELATIONS_RENDERING_STRATEGY = 'RELATIONS'
-ATTRIBUTE_RENDERING_STRATEGY = 'ATTRIBUTE'
-
 DEFAULTS = {
     'FORMAT_FIELD_NAMES': False,
     'FORMAT_TYPES': False,
@@ -32,12 +29,14 @@ def __init__(self, user_settings=settings, defaults=DEFAULTS):
         self.defaults = defaults
         self.user_settings = user_settings
 
+        field_name = JSON_API_SETTINGS_PREFIX + 'SERIALIZE_NESTED_SERIALIZERS_AS_ATTRIBUTE'
+
         value = getattr(
             self.user_settings,
-            JSON_API_SETTINGS_PREFIX + 'SERIALIZE_NESTED_SERIALIZERS_AS_ATTRIBUTE',
+            field_name,
             self.defaults['SERIALIZE_NESTED_SERIALIZERS_AS_ATTRIBUTE'])
 
-        if not value and not hasattr(self.user_settings, JSON_API_SETTINGS_PREFIX + 'SERIALIZE_NESTED_SERIALIZERS_AS_ATTRIBUTE'):
+        if not value and not hasattr(self.user_settings, field_name):
             warnings.warn(DeprecationWarning(
                 "Rendering nested serializers in relations by default is deprecated and will be "
                 "changed in future releases. Please, use ResourceRelatedField or set "