Skip to content

Define what Python, Django and DRF series are supported #839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 16, 2020

Conversation

sliverc
Copy link
Member

@sliverc sliverc commented Oct 15, 2020

Description of the Change

Currently whenever a Python, Django and Django REST framework series is end of life there is a conversation on when to drop it. I think for a user of DJA it is good to have this defined to avoid surprises.

Django REST framework does not really have an end of life definition (or have I overlooked this?) so supporting the last two series is feasible. In our upcoming release 4.0.0 we actually started supporting a new DRF release and dropping all lower DRF versions. Therefore a user is forced to update DJA and DRF at the same time.

I think it is fine for this round but should be avoided this in the future.

This PR should be the basis of discussion and can also be merged after the release of 4.0.0 whatever fits best.

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

@sliverc sliverc requested a review from n2ygk October 15, 2020 13:43
@codecov
Copy link

codecov bot commented Oct 15, 2020

Codecov Report

Merging #839 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #839   +/-   ##
=======================================
  Coverage   97.76%   97.76%           
=======================================
  Files          58       58           
  Lines        3089     3089           
=======================================
  Hits         3020     3020           
  Misses         69       69           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab3fbfc...360dcb2. Read the comment docs.

@n2ygk n2ygk merged commit 15f5424 into django-json-api:master Oct 16, 2020
@sliverc sliverc deleted the supported_series branch October 16, 2020 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants