Add php-7.0.0alpha2 (Issue #108) #109
Conversation
Switch from "bz2" to "xz" for 5.5 and 5.6 …
| @@ -3,6 +3,7 @@ set -e | |||
|
|
|||
| declare -A gpgKeys | |||
| gpgKeys=( | |||
| [7.0.0alpha2]='1A4E8B7277C42E53DBA9C7B9BCAA30EA9C0D5763' | |||
There was a problem hiding this comment.
Can you please rename the folder to just be 7.0?
|
@tianon I've updated the code as you suggested. |
| RUN set -xe \ | ||
| && for key in $GPG_KEYS; do \ | ||
| gpg --keyserver ha.pool.sks-keyservers.net --recv-keys "$key"; \ | ||
| done |
There was a problem hiding this comment.
I would just drop the gpg key env and downloading, since it is unused and will probably change on the release anyway.
There was a problem hiding this comment.
@yosifkit this code will be kept when the 7.0 goes to production in that case we will make it compatible with 5.6 and verify the download.
There was a problem hiding this comment.
As you point out, this file will need to be edited to actually do the gpg verify when 7.0 is released. Having this key serves no purpose in the image and will likely be a different key on release anyway.
There was a problem hiding this comment.
@yosifkit Ok removed
|
You should replace |
|
I've rebased/carried this PR over in #113. 👍 |
|
Ok thanks @tianon |
|
No, thank you! I'm excited to finally see PHP 7 in a form people can
easily play with! 😄
|
- `golang`: 1.5beta1 - `mysql`: time zones (docker-library/mysql#80) - `php`: 7.0.0beta1 (docker-library/php#113, docker-library/php#109) - `postgres`: 9.5-alpha1 (docker-library/postgres#70), jessie (docker-library/postgres#71)
- `golang`: 1.5beta1 - `mysql`: time zones (docker-library/mysql#80) - `php`: 7.0.0beta1 (docker-library/php#113, docker-library/php#109) - `postgres`: 9.5-alpha1 (docker-library/postgres#70), jessie (docker-library/postgres#71)
I've modified update.sh to support versions without gpg signature verification
The dockerfile on 7.0.0alpha2 directory was modified a bit to download the file from another location without gpg verfication, this will be fixed when 7 goes stable and we have the .asc file to verify.
the gpg key from php 7 was found on http://php.net/gpg-keys.php
generate-stackbrew-library.shworks without issues.