Apply suggestions from code review

halter73 · Kahbazi · davidfowl · web-flow · commit 6594c905fe50 · 2022-07-22T14:37:28.000-07:00
Co-authored-by: Kahbazi &lt;A.Kahbazi@gmail.com&gt;
Co-authored-by: David Fowler &lt;davidfowl@gmail.com&gt;
diff --git a/src/Http/Routing/src/Builder/EndpointRouteBuilderExtensions.cs b/src/Http/Routing/src/Builder/EndpointRouteBuilderExtensions.cs
@@ -426,7 +426,7 @@ private static RouteEndpointDataSource GetOrAddRouteEndpointDataSource(this IEnd
             var routeHandlerOptions = endpoints.ServiceProvider?.GetService<IOptions<RouteHandlerOptions>>();
             var throwOnBadRequest = routeHandlerOptions?.Value.ThrowOnBadRequest ?? false;
 
-            routeEndpointDataSource = new RouteEndpointDataSource(endpoints.ServiceProvider ?? new EmptyServiceProvider(), throwOnBadRequest);
+            routeEndpointDataSource = new RouteEndpointDataSource(endpoints.ServiceProvider ?? EmptyServiceProvider.Instance, throwOnBadRequest);
             endpoints.DataSources.Add(routeEndpointDataSource);
         }
 
diff --git a/src/Http/Routing/test/UnitTests/RouteEndpointBuilderTest.cs b/src/Http/Routing/test/UnitTests/RouteEndpointBuilderTest.cs
@@ -32,7 +32,6 @@ public void Build_AllValuesSet_EndpointCreated()
     [Fact]
     public async void Build_DoesNot_RunFilters()
     {
-
         var endpointFilterCallCount = 0;
         var invocationFilterCallCount = 0;
         var invocationCallCount = 0;

Original file line number	Diff line number	Diff line change
`@@ -426,7 +426,7 @@ private static RouteEndpointDataSource GetOrAddRouteEndpointDataSource(this IEnd`
`426`	`426`	`var routeHandlerOptions = endpoints.ServiceProvider?.GetService<IOptions<RouteHandlerOptions>>();`
`427`	`427`	`var throwOnBadRequest = routeHandlerOptions?.Value.ThrowOnBadRequest ?? false;`
`428`	`428`
`429`		`- routeEndpointDataSource = new RouteEndpointDataSource(endpoints.ServiceProvider ?? new EmptyServiceProvider(), throwOnBadRequest);`
	`429`	`+ routeEndpointDataSource = new RouteEndpointDataSource(endpoints.ServiceProvider ?? EmptyServiceProvider.Instance, throwOnBadRequest);`
`430`	`430`	`endpoints.DataSources.Add(routeEndpointDataSource);`
`431`	`431`	`}`
`432`	`432`
Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,6 @@ public void Build_AllValuesSet_EndpointCreated()`
`32`	`32`	`[Fact]`
`33`	`33`	`public async void Build_DoesNot_RunFilters()`
`34`	`34`	`{`
`35`		`-`
`36`	`35`	`var endpointFilterCallCount = 0;`
`37`	`36`	`var invocationFilterCallCount = 0;`
`38`	`37`	`var invocationCallCount = 0;`