backport 8.0 - http.sys accept loop - mitigate against break due to possible conflicting IO callbacks #54437
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. handle MRTVS cascading fault breaking the accept loop 2. log any expectation failures # Conflicts: # src/Servers/HttpSys/src/AsyncAcceptContext.cs
…itching - lock new critical log messages behind app-context switch
ghost
added
the
area-infrastructure
mgravell
added
Servicing-consider
mgravell
requested review from
halter73,
BrennanConroy and
JamesNK
as code owners
amcasey
removed
the
area-infrastructure
mgravell
added
Servicing-approved
|
approved by servicing tactics 8th /cc @wtgodbe |
|
@adityamandaleeka @Tratcher @halter73 @JamesNK code review approval needed ASAP |
halter73
reviewed
Mar 11, 2024
| var value = Interlocked.Exchange(ref _expectedCompletionCount, 1); // should have been 0 | ||
| if (value != 0) | ||
| { | ||
| if (_logExpectationFailures) |
There was a problem hiding this comment.
Why even gate this behind a flag? I doubt many people will know to turn it on, and if these are failing commonly, wouldn't we want to hear about it? You could disable the HttpSysListener logger if it's too noisy.
Or at least make it opt-out. This is another case where being able to filter logs by event ID would be nice. dotnet/runtime#49924
halter73
approved these changes
Mar 11, 2024
| { | ||
| Log.AcceptSetExpectationMismatch(_logger, value); | ||
| } | ||
| Debug.Assert(false, nameof(SetExpectCompletion)); // fail hard in debug |
There was a problem hiding this comment.
Nit:
Suggested change
| Debug.Assert(false, nameof(SetExpectCompletion)); // fail hard in debug | |
| Debug.Fail($"nameof(SetExpectCompletion) - {value}"); // fail hard in debug |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport #54368 to .NET 8
Context: #54251
System.InvalidOperationException: NativeOverlapped cannot be reused for multiple operations after .NET 6 to .NET 8 upgrade
This manifests as a fatal exception in the http.sys "accept" loop, which can either:
Description
Apply mitigation and logging
Fixes #54251
Customer Impact
without fix, http.sys web-server stops taking traffic (best case) or segfaults
Regression?
believed to be a regression since .net 6; scenario is hard to repro reliably
Risk
This change is "fresh", and hasn't been validated in nightly (or even merged to "main"); the technical changes are minor (logging, improved error handling), and the competing behaviour is catastrophic.