Skip to content

Storage account for Copilot language server #8408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Jul 22, 2025

Conversation

AbhitejJohn
Copy link
Contributor

@AbhitejJohn AbhitejJohn commented Jul 9, 2025

This is primarily an implementation of David Barbet's suggestion that helps with our dev inner-loop reducing the amount of dependencies across repos. With the roslyn copilot language server coming in from the storage account, changes are no longer required in C# Dev Kit to point to the right language server.

Todo

  • Deploy the bits to the storage account.
  • Ensure there is a pipeline that can deploy.
  • Update vs-green to skip pulling in the bits.
  • Orchestrate a release.

Validation

Ensured that the context provider is indeed invoked after my changes. It pulls in the binary from the new location. So this was a debug setup on a windows devbox. I do not think other OS's could cause a problem but I'll figure out what it would take to validate this on mac and linux as well.

…nt instead of relying on its presence in C# Dev Kit.
Copy link
Member

@dibarbet dibarbet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

know this is a draft, just wanted to make a couple small notes

@AbhitejJohn
Copy link
Contributor Author

know this is a draft, just wanted to make a couple small notes

Thank you, feedback is welcome. This is change is mostly ready. I'm just trying to get the bits deployed, so I can update the url and the sha before its good to merge.

Copy link
Member

@dibarbet dibarbet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, pending the package.nls.json fix

@AbhitejJohn AbhitejJohn marked this pull request as ready for review July 22, 2025 20:48
@AbhitejJohn AbhitejJohn requested a review from a team as a code owner July 22, 2025 20:48
@AbhitejJohn AbhitejJohn enabled auto-merge July 22, 2025 21:09
@AbhitejJohn AbhitejJohn merged commit 4d50c24 into dotnet:main Jul 22, 2025
24 checks passed
@AbhitejJohn AbhitejJohn deleted the storageaccountcopilotls branch July 22, 2025 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants