Storage account for Copilot language server #8408
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt instead of relying on its presence in C# Dev Kit.
AbhitejJohn
commented
Jul 9, 2025
AbhitejJohn
commented
Jul 9, 2025
dibarbet
reviewed
Jul 9, 2025
Thank you, feedback is welcome. This is change is mostly ready. I'm just trying to get the bits deployed, so I can update the url and the sha before its good to merge. |
AbhitejJohn
commented
Jul 10, 2025
dibarbet
reviewed
Jul 21, 2025
dibarbet
approved these changes
Jul 21, 2025
…" folder to gitignore for dev workflows.
dibarbet
approved these changes
Jul 22, 2025
JoeRobich
approved these changes
Jul 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is primarily an implementation of David Barbet's suggestion that helps with our dev inner-loop reducing the amount of dependencies across repos. With the roslyn copilot language server coming in from the storage account, changes are no longer required in C# Dev Kit to point to the right language server.
Todo
Validation
Ensured that the context provider is indeed invoked after my changes. It pulls in the binary from the new location. So this was a debug setup on a windows devbox. I do not think other OS's could cause a problem but I'll figure out what it would take to validate this on mac and linux as well.