-
Notifications
You must be signed in to change notification settings - Fork 716
Storage account for Copilot language server #8408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Storage account for Copilot language server #8408
Conversation
…nt instead of relying on its presence in C# Dev Kit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
know this is a draft, just wanted to make a couple small notes
Thank you, feedback is welcome. This is change is mostly ready. I'm just trying to get the bits deployed, so I can update the url and the sha before its good to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, pending the package.nls.json fix
…" folder to gitignore for dev workflows.
This is primarily an implementation of David Barbet's suggestion that helps with our dev inner-loop reducing the amount of dependencies across repos. With the roslyn copilot language server coming in from the storage account, changes are no longer required in C# Dev Kit to point to the right language server.
Todo
Validation
Ensured that the context provider is indeed invoked after my changes. It pulls in the binary from the new location. So this was a debug setup on a windows devbox. I do not think other OS's could cause a problem but I'll figure out what it would take to validate this on mac and linux as well.