-
-
Notifications
You must be signed in to change notification settings - Fork 516
Component Patterns Updates #1463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, @hergaiety. I think the passages that you wrote look good overall. I made a few suggestions that I think will help improve the passages.
Let me request:
- Making changes for Ember 3.15 - release (currently 3.19), not just 3.17.
- Making an
h2
-level title so that people can link to the new section.
Co-authored-by: Isaac Lee <[email protected]>
@ijlee2 great ideas, I also believe I've learned now how to update multiple versions of the guides. :) Thanks |
@hergaiety Thanks! Can I ask for 1 more change? I noticed that your branch doesn't contain code for 3.18 and 3.19, so I'm not sure how your code changes for To be safe, I think you will want to fetch the latest (something like https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/syncing-a-fork), then make changes to:
|
Done @ijlee2 thanks again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thank you for contributing to the Guides!
To maintainers: I noticed that 92 Percy snapshots were marked as new. I think this is because I updated the Firefox version last week. I skimmed the new snapshots and believe they are all right.
Adjustments to opening paragraph prose.
Link to ember-component-patterns for more patterns, anti-patterns and accessibility for common Ember topics. It is my hope that this app is gaining traction along with support from the Ember A11y community in Discord and Mel Sumner's pushes for more pattern coverage.
Preview of bottom section with image: