Skip to content

Component Patterns Updates #1463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 29, 2020
Merged

Conversation

hergaiety
Copy link
Contributor

Adjustments to opening paragraph prose.

Link to ember-component-patterns for more patterns, anti-patterns and accessibility for common Ember topics. It is my hope that this app is gaining traction along with support from the Ember A11y community in Discord and Mel Sumner's pushes for more pattern coverage.

Preview of bottom section with image:

Screen Shot 2020-06-25 at 11 24 47 PM

Copy link
Member

@ijlee2 ijlee2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @hergaiety. I think the passages that you wrote look good overall. I made a few suggestions that I think will help improve the passages.

Let me request:

  • Making changes for Ember 3.15 - release (currently 3.19), not just 3.17.
  • Making an h2-level title so that people can link to the new section.

@hergaiety
Copy link
Contributor Author

@ijlee2 great ideas, I also believe I've learned now how to update multiple versions of the guides. :) Thanks

@ijlee2
Copy link
Member

ijlee2 commented Jun 29, 2020

@hergaiety Thanks! Can I ask for 1 more change?

I noticed that your branch doesn't contain code for 3.18 and 3.19, so I'm not sure how your code changes for release folder may end up getting merged.

To be safe, I think you will want to fetch the latest (something like https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/syncing-a-fork), then make changes to:

  • guides/v3.15.0/in-depth-topics/patterns-for-components.md
  • guides/v3.16.0/in-depth-topics/patterns-for-components.md
  • guides/v3.17.0/in-depth-topics/patterns-for-components.md
  • guides/v3.18.0/in-depth-topics/patterns-for-components.md
  • guides/release/in-depth-topics/patterns-for-components.md

@hergaiety
Copy link
Contributor Author

Done @ijlee2 thanks again

Copy link
Member

@ijlee2 ijlee2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you for contributing to the Guides!

To maintainers: I noticed that 92 Percy snapshots were marked as new. I think this is because I updated the Firefox version last week. I skimmed the new snapshots and believe they are all right.

@ijlee2 ijlee2 merged commit 390705b into ember-learn:master Jun 29, 2020
@hergaiety hergaiety deleted the patterns-update branch June 30, 2020 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants