-
-
Notifications
You must be signed in to change notification settings - Fork 515
Add A11y Mascots to Accessibility Index #1477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi, @hergaiety. It looks like you combined two Ember mascots to create the image. I wanted to confirm if we need approval from Leah Silber to modify the mascots (maybe you already did?). https://emberjs.com/mascots/faq |
@wifelette Hello! 👋 When you get a chance, would you mind reviewing this PR so that we may have your approval for use of mascots? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me!
Hi! Sorry for the delay. @hergaiety Can you confirm that the only modification is the placement + blurring of the Tomster? If so, A+, and it looks good. If it's more, please list the modifications so I can review them with Lindsey :) |
@wifelette I technically also hid the rights reserved symbol over Tomster's right hand as it was blurred. There's still a rights reserved symbol over Zoey's left hand, and it's all one image tightly grouped together so I don't believe this is an issue. No other visual changes were made. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for clarifying, this looks good to go then from me!
@hergaiety I'll go ahead and merge this PR. Can you make a follow-up PR to introduce the picture to |
Continuing the effort (#1463, #1466, #1467) of adding visuals to the Ember Guides for visual interest of developers, breaking up walls of text and generally enhancing the guides visual appearance. This PR adds the Ember A11y versions of the Zoey and Tomster mascots in a stylized way to the intro page of the Accessibility section.
Preview