Skip to content

Add A11y Mascots to Accessibility Index #1477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 6, 2020

Conversation

hergaiety
Copy link
Contributor

@hergaiety hergaiety commented Jul 11, 2020

Continuing the effort (#1463, #1466, #1467) of adding visuals to the Ember Guides for visual interest of developers, breaking up walls of text and generally enhancing the guides visual appearance. This PR adds the Ember A11y versions of the Zoey and Tomster mascots in a stylized way to the intro page of the Accessibility section.

Preview

Screen Shot 2020-07-10 at 10 31 47 PM

@ijlee2
Copy link
Member

ijlee2 commented Jul 13, 2020

Hi, @hergaiety. It looks like you combined two Ember mascots to create the image. I wanted to confirm if we need approval from Leah Silber to modify the mascots (maybe you already did?). https://emberjs.com/mascots/faq

@ijlee2
Copy link
Member

ijlee2 commented Jul 26, 2020

@wifelette Hello! 👋 When you get a chance, would you mind reviewing this PR so that we may have your approval for use of mascots?

Copy link
Contributor

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me!

@wifelette
Copy link
Member

Hi! Sorry for the delay. @hergaiety Can you confirm that the only modification is the placement + blurring of the Tomster? If so, A+, and it looks good. If it's more, please list the modifications so I can review them with Lindsey :)

@hergaiety
Copy link
Contributor Author

@wifelette I technically also hid the rights reserved symbol over Tomster's right hand as it was blurred. There's still a rights reserved symbol over Zoey's left hand, and it's all one image tightly grouped together so I don't believe this is an issue.

No other visual changes were made.

ijlee2
ijlee2 previously approved these changes Jul 29, 2020
@ijlee2 ijlee2 dismissed their stale review July 29, 2020 14:27

Will wait for Leah's approval, my bad.

Copy link
Member

@wifelette wifelette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for clarifying, this looks good to go then from me!

@ijlee2
Copy link
Member

ijlee2 commented Aug 6, 2020

@hergaiety I'll go ahead and merge this PR. Can you make a follow-up PR to introduce the picture to /guides/v3.19.0?

@ijlee2 ijlee2 merged commit a15d694 into ember-learn:master Aug 6, 2020
@hergaiety hergaiety deleted the a11y-mascot-index branch August 6, 2020 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants