Skip to content

Visuals for Input/Label Patterns #1479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 13, 2020

Conversation

hergaiety
Copy link
Contributor

Continuing the effort (#1463, #1466, #1467) of adding visuals to the Ember Guides

Adds two illustrations to visually demonstrate the difference between Accessible names via Input Label nested VS tied together with id/for.

Also adds a Zoey says that links to a relevant approved (and written by) Melanie Sumners on the topic in more detail.

Screen Shot 2020-07-12 at 2 40 34 PM

Screen Shot 2020-07-12 at 2 40 37 PM

Copy link
Member

@ijlee2 ijlee2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you for creating the images!

@ijlee2 ijlee2 merged commit a400cf3 into ember-learn:master Jul 13, 2020
@hergaiety hergaiety deleted the component-label-inputs branch July 13, 2020 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants