Skip to content

Commit cb6c5ec

Browse files
[ci] Wait for LUCI test checkin in release (flutter#4911)
Avoid the possibilty of the `release` action's wait-for-all-tests step completing before any LUCI tests have even checked in, by first waiting for a known LUCI test to show up.
1 parent b3138a6 commit cb6c5ec

File tree

1 file changed

+16
-0
lines changed

1 file changed

+16
-0
lines changed

.github/workflows/release.yml

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,22 @@ jobs:
4343
run: dart pub get
4444
working-directory: ${{ github.workspace }}/script/tool
4545

46+
# The next step waits for all tests, but when there are issues with the
47+
# hooks it can take a long time for the tests to even be registered. If
48+
# "Wait on all tests" runs before that happens, it will pass immediately
49+
# because there doesn't appear to be anything to wait for. To avoid that,
50+
# explicitly wait for one LUCI test by name first.
51+
- name: Wait for test check-in
52+
uses: lewagon/wait-on-check-action@e106e5c43e8ca1edea6383a39a01c5ca495fd812
53+
with:
54+
ref: ${{ github.sha }}
55+
check-name: 'Linux ci_yaml packages roller'
56+
repo-token: ${{ secrets.GITHUB_TOKEN }}
57+
wait-interval: 30 # seconds
58+
allowed-conclusions: success,neutral
59+
# verbose:true will produce too many logs that hang github actions web UI.
60+
verbose: false
61+
4662
# This workflow should be the last to run. So wait for all the other tests to succeed.
4763
- name: Wait on all tests
4864
uses: lewagon/wait-on-check-action@e106e5c43e8ca1edea6383a39a01c5ca495fd812

0 commit comments

Comments
 (0)