eof: Add and update tests.

Author: rodiazet

libyul/backends/evm/EVMDialect.cpp

@@ -435,7 +435,7 @@ std::vector<std::optional<BuiltinFunctionForEVM>> createBuiltins(langutil::EVMVe
 			1,
 			EVMDialect::sideEffectsOfInstruction(evmasm::Instruction::EOFCREATE),
 			ControlFlowSideEffects::fromInstruction(evmasm::Instruction::EOFCREATE),
-			// TODO: Personaly I don't like this solution but cannot find any better way to prevent 9114 error in asm analysis.
+			// TODO: Personally I don't like this solution but cannot find any better way to prevent 9114 error in asm analysis.
 			{_objectAccess ? LiteralKind::String : std::optional<LiteralKind>{}, std::nullopt, std::nullopt, std::nullopt, std::nullopt},
 			[](
 				FunctionCall const& _call,

test/libsolidity/semanticTests/inlineAssembly/objectName.sol

@@ -0,0 +1,28 @@
+contract B
+{
+    function f() public returns (uint ret){
+        ret = 123;
+    }
+}
+
+contract C {
+    B b;
+
+    function f() public {
+        B t;
+        assembly {
+            t := eofcreate(B.objectName, 0, 0, 0, 0)
+        }
+
+        b = t;
+    }
+
+    function run_B_f() public returns (uint) {
+        return b.f();
+    }
+}
+// ====
+// bytecodeFormat: >=EOFv1
+// ----
+// f()
+// run_B_f() -> 123

test/libsolidity/semanticTests/inlineAssembly/objectNameLibrary.sol

@@ -0,0 +1,34 @@
+library Lib {
+    struct S {
+        uint v;
+    }
+    function add(uint a, uint b) external pure returns(uint ret) {
+        ret = a + b;
+    }
+}
+
+interface ILib {
+    function add(uint a, uint b) external pure returns (uint);
+}
+
+contract C {
+    address addr;
+
+    function create_lib() public {
+        address l;
+        assembly {
+            l := eofcreate(Lib.objectName, 0, 0, 0, 0)
+
+        }
+        addr = l;
+    }
+
+    function add() public returns(uint){
+        return ILib(addr).add(5, 7);
+    }
+}
+// ====
+// bytecodeFormat: >=EOFv1
+// ----
+// create_lib()
+// add() -> 12

test/libsolidity/syntaxTests/inlineAssembly/eof/storage_reference_on_function.sol

@@ -0,0 +1,11 @@
+contract C {
+    function f() pure public {
+        assembly {
+            let x := f.slot
+        }
+    }
+}
+// ====
+// bytecodeFormat: >=EOFv1
+// ----
+// TypeError 9479: (84-90): The suffixes ".offset", ".slot" and ".length" can only be used with variables or the suffix "objectName" can be used with a contract name identifier.

test/libsolidity/syntaxTests/inlineAssembly/invalid/eof/eof_builtins_disallowed.sol

@@ -10,6 +10,6 @@ contract C {
 // ====
 // bytecodeFormat: legacy
 // ----
-// DeclarationError 7223: (75-84): Builtin function "eofcreate" is only available in EOF.
+// TypeError 4328: (75-84): The "eofcreate" instruction is only available in EOF.
 // DeclarationError 7223: (114-128): Builtin function "returncontract" is only available in EOF.
 // DeclarationError 7223: (149-161): Builtin function "auxdataloadn" is only available in EOF.

test/libsolidity/syntaxTests/inlineAssembly/invalid/eof/eof_builtins_disallowed_in_inline_assembly.sol

@@ -2,7 +2,6 @@
 contract C {
     function f() view public {
         assembly {
-            eofcreate("a", 0, 0, 0, 0)
             returncontract("a", 0)
             auxdataloadn(0)
         }
@@ -11,6 +10,5 @@ contract C {
 // ====
 // bytecodeFormat: >=EOFv1
 // ----
-// DeclarationError 4619: (186-195): Function "eofcreate" not found.
-// DeclarationError 4619: (225-239): Function "returncontract" not found.
-// DeclarationError 4619: (260-272): Function "auxdataloadn" not found.
+// DeclarationError 4619: (186-200): Function "returncontract" not found.
+// DeclarationError 4619: (221-233): Function "auxdataloadn" not found.

test/libsolidity/syntaxTests/inlineAssembly/invalidContractDefinitionSuffix.sol

@@ -0,0 +1,14 @@
+contract B {}
+
+contract C {
+    function f() public {
+        B b;
+        assembly {
+            b := eofcreate(B.objectId, 0, 0, 0, 0)
+        }
+    }
+}
+// ====
+// bytecodeFormat: >=EOFv1
+// ----
+// DeclarationError 8198: (113-123): Identifier "B.objectId" not found.

test/libsolidity/syntaxTests/inlineAssembly/objectName.sol

@@ -0,0 +1,12 @@
+contract B {}
+
+contract C {
+    function f() public {
+        B b;
+        assembly {
+            b := eofcreate(B.objectName, 0, 0, 0, 0)
+        }
+    }
+}
+// ====
+// bytecodeFormat: >=EOFv1

test/libsolidity/syntaxTests/inlineAssembly/objectNameAsVariableSuffix.sol

@@ -0,0 +1,15 @@
+contract C {
+    uint s;
+    function f() public {
+        uint b;
+        assembly {
+            b := s.objectName
+            b := b.objectName
+        }
+    }
+}
+// ====
+// bytecodeFormat: >=EOFv1
+// ----
+// TypeError 4656: (103-115): State variables only support ".slot" and ".offset".
+// TypeError 3622: (133-145): The suffix ".objectName" is not supported by this variable or type.

test/libsolidity/syntaxTests/inlineAssembly/objectNameInLegacy.sol

@@ -0,0 +1,16 @@
+contract B {}
+
+contract C {
+    function f() public {
+        B b;
+        assembly {
+            b := eofcreate(B.objectName, 0, 0, 0, 0)
+        }
+    }
+}
+// ====
+// bytecodeFormat: legacy
+// ----
+// TypeError 4328: (103-112): The "eofcreate" instruction is only available in EOF.
+// TypeError 1342: (113-125): ".objectName" suffix is supported only for contract name identifier when compiling to EOF.
+// DeclarationError 8678: (98-138): Variable count for assignment to "b" does not match number of values (1 vs. 0)