From 2bf092967ff7437fb4b4c7a9734cca49faa22267 Mon Sep 17 00:00:00 2001 From: Bond Date: Thu, 18 Jan 2018 12:55:02 +0100 Subject: [PATCH 01/13] pin envinfo version to 3.4.2 (#3853) See #3837 --- packages/create-react-app/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/create-react-app/package.json b/packages/create-react-app/package.json index 65ab56a1698..e1fe32f00cf 100644 --- a/packages/create-react-app/package.json +++ b/packages/create-react-app/package.json @@ -24,7 +24,7 @@ "chalk": "^1.1.1", "commander": "^2.9.0", "cross-spawn": "^4.0.0", - "envinfo": "^3.8.0", + "envinfo": "3.4.2", "fs-extra": "^1.0.0", "hyperquest": "^2.1.2", "semver": "^5.0.3", From 034c6ad348416b1067fa3a389b163ddf0cfaeef6 Mon Sep 17 00:00:00 2001 From: Dan Abramov Date: Thu, 18 Jan 2018 12:08:58 +0000 Subject: [PATCH 02/13] 1.5.1 --- packages/create-react-app/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/create-react-app/package.json b/packages/create-react-app/package.json index e1fe32f00cf..93d7b00ad90 100644 --- a/packages/create-react-app/package.json +++ b/packages/create-react-app/package.json @@ -1,6 +1,6 @@ { "name": "create-react-app", - "version": "1.5.0", + "version": "1.5.1", "keywords": [ "react" ], From bab2c295220a88f1ea5bdabd0bf65fb7c7a98152 Mon Sep 17 00:00:00 2001 From: Robin van der Vleuten Date: Sat, 20 Jan 2018 20:31:27 +0100 Subject: [PATCH 03/13] Set the public path to the asset manifest entries (#2544) --- packages/react-scripts/config/webpack.config.prod.js | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/react-scripts/config/webpack.config.prod.js b/packages/react-scripts/config/webpack.config.prod.js index 3b2a2068db2..83bcadb63cd 100644 --- a/packages/react-scripts/config/webpack.config.prod.js +++ b/packages/react-scripts/config/webpack.config.prod.js @@ -319,6 +319,7 @@ module.exports = { // having to parse `index.html`. new ManifestPlugin({ fileName: 'asset-manifest.json', + publicPath: publicPath }), // Generate a service worker script that will precache, and keep up to date, // the HTML & assets that are part of the Webpack build. From eee29075d64a4d3c2c5af4f4b9836e54e8f8bb3e Mon Sep 17 00:00:00 2001 From: Ronald Rey Date: Mon, 22 Jan 2018 09:51:38 -0400 Subject: [PATCH 04/13] Include `{json,css}` files in prettier command (#3894) Update User Guide's README.md to include `json` and `css` files in the command to format the entire project for the first time with prettier, that it's consistent with the `lint-staged` command. --- packages/react-scripts/template/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react-scripts/template/README.md b/packages/react-scripts/template/README.md index 7c641456056..3fe1b8c48db 100644 --- a/packages/react-scripts/template/README.md +++ b/packages/react-scripts/template/README.md @@ -348,7 +348,7 @@ Next we add a 'lint-staged' field to the `package.json`, for example: "scripts": { ``` -Now, whenever you make a commit, Prettier will format the changed files automatically. You can also run `./node_modules/.bin/prettier --single-quote --write "src/**/*.{js,jsx}"` to format your entire project for the first time. +Now, whenever you make a commit, Prettier will format the changed files automatically. You can also run `./node_modules/.bin/prettier --single-quote --write "src/**/*.{js,jsx,json,css}"` to format your entire project for the first time. Next you might want to integrate Prettier in your favorite editor. Read the section on [Editor Integration](https://prettier.io/docs/en/editors.html) on the Prettier GitHub page. From 815853db7fdd1f372701ecc09f90b7d5b45f7b87 Mon Sep 17 00:00:00 2001 From: Alf Eaton Date: Sun, 4 Feb 2018 15:54:14 +0000 Subject: [PATCH 05/13] Update instructions for continuous delivery with Netlify (#3971) --- packages/react-scripts/template/README.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/react-scripts/template/README.md b/packages/react-scripts/template/README.md index 3fe1b8c48db..d40c87ebc81 100644 --- a/packages/react-scripts/template/README.md +++ b/packages/react-scripts/template/README.md @@ -2264,7 +2264,8 @@ With this setup Netlify will build and deploy when you push to git or open a pul 1. [Start a new netlify project](https://app.netlify.com/signup) 2. Pick your Git hosting service and select your repository -3. Click `Build your site` +3. Set `yarn build` as the build command and `build` as the publish directory +4. Click `Deploy site` **Support for client-side routing:** From 32ea0c0e6d886aab35ec2f476605b5a1cb0a0095 Mon Sep 17 00:00:00 2001 From: Ian Sutherland Date: Fri, 9 Feb 2018 05:08:30 -0800 Subject: [PATCH 06/13] Update dotenv-expand to fix bug with environment variables that contain a $. (#4000) --- packages/react-scripts/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react-scripts/package.json b/packages/react-scripts/package.json index 91d4a584cf4..41ff76e8544 100644 --- a/packages/react-scripts/package.json +++ b/packages/react-scripts/package.json @@ -32,7 +32,7 @@ "chalk": "1.1.3", "css-loader": "0.28.7", "dotenv": "4.0.0", - "dotenv-expand": "4.0.1", + "dotenv-expand": "4.2.0", "eslint": "4.10.0", "eslint-config-react-app": "^2.1.0", "eslint-loader": "1.9.0", From 09d216ecce97a6cabf8e34a97c82b6acff82f27e Mon Sep 17 00:00:00 2001 From: Dan Abramov Date: Fri, 9 Feb 2018 13:10:41 +0000 Subject: [PATCH 07/13] Unpin and bump fsevents (for 1.x branch) (#4006) --- packages/react-scripts/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react-scripts/package.json b/packages/react-scripts/package.json index 41ff76e8544..b8f1006e5b2 100644 --- a/packages/react-scripts/package.json +++ b/packages/react-scripts/package.json @@ -64,6 +64,6 @@ "react-dom": "^16.0.0" }, "optionalDependencies": { - "fsevents": "1.1.2" + "fsevents": "^1.1.3" } } From 984d661811299ce2256b81ea65258037ac65e68e Mon Sep 17 00:00:00 2001 From: Dan Abramov Date: Fri, 9 Feb 2018 13:19:49 +0000 Subject: [PATCH 08/13] Add 1.1.1 changelog --- CHANGELOG.md | 40 ++++++++++++++++++++++++++++++++++++++++ 1 file changed, 40 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index a2dfec8fec6..b79db6b8786 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,43 @@ +## 1.1.1 (February 2, 2018) + +#### :bug: Bug Fix +* `react-scripts` + * [#4000](https://github.com/facebook/create-react-app/pull/4000) Fix escaping `$` in environment variables. ([@iansu](https://github.com/iansu)) + +#### :nail_care: Enhancement +* `react-scripts` + * [#4006](https://github.com/facebook/create-react-app/pull/4006) Add Node 9 compatibility for `fsevents`. ([@gaearon](https://github.com/gaearon)) + +#### :memo: Documentation +* `react-scripts` + * [#3971](https://github.com/facebook/create-react-app/pull/3971) Update instructions for continuous delivery with Netlify. ([@hubgit](https://github.com/hubgit)) + * [#3894](https://github.com/facebook/create-react-app/pull/3894) Include `{json,css}` files in prettier command. ([@reyronald](https://github.com/reyronald)) + +#### :house: Internal +* `create-react-app` + * [#3853](https://github.com/facebook/create-react-app/pull/3853) pin envinfo version to 3.4.2. ([@bondz](https://github.com/bondz)) + +#### Committers: 6 +- Alf Eaton ([hubgit](https://github.com/hubgit)) +- Bond ([bondz](https://github.com/bondz)) +- Dan Abramov ([gaearon](https://github.com/gaearon)) +- Ian Sutherland ([iansu](https://github.com/iansu)) +- Ronald Rey ([reyronald](https://github.com/reyronald)) + +### Migrating from 1.1.0 to 1.1.1 + +Inside any created project that has not been ejected, run: + +``` +npm install --save --save-exact react-scripts@1.1.1 +``` + +or + +``` +yarn add --exact react-scripts@1.1.1 +``` + ## 1.1.0 (January 15, 2018) #### :rocket: New Feature From 1a9722f50a8b8786803c1f784efca366a43f38da Mon Sep 17 00:00:00 2001 From: Dan Abramov Date: Fri, 9 Feb 2018 13:13:49 +0000 Subject: [PATCH 09/13] Revert "Set the public path to the asset manifest entries (#2544)" This reverts commit bab2c295220a88f1ea5bdabd0bf65fb7c7a98152. I meant to apply it to `next` instead. --- packages/react-scripts/config/webpack.config.prod.js | 1 - 1 file changed, 1 deletion(-) diff --git a/packages/react-scripts/config/webpack.config.prod.js b/packages/react-scripts/config/webpack.config.prod.js index 83bcadb63cd..3b2a2068db2 100644 --- a/packages/react-scripts/config/webpack.config.prod.js +++ b/packages/react-scripts/config/webpack.config.prod.js @@ -319,7 +319,6 @@ module.exports = { // having to parse `index.html`. new ManifestPlugin({ fileName: 'asset-manifest.json', - publicPath: publicPath }), // Generate a service worker script that will precache, and keep up to date, // the HTML & assets that are part of the Webpack build. From 0b1d6365768ae3bd267b042b74bab249673f1a9f Mon Sep 17 00:00:00 2001 From: Dan Abramov Date: Fri, 9 Feb 2018 13:20:59 +0000 Subject: [PATCH 10/13] Publish - create-react-app@1.5.2 - react-scripts@1.1.1 --- packages/create-react-app/package.json | 2 +- packages/react-scripts/package.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/create-react-app/package.json b/packages/create-react-app/package.json index 93d7b00ad90..4d8f4112ead 100644 --- a/packages/create-react-app/package.json +++ b/packages/create-react-app/package.json @@ -1,6 +1,6 @@ { "name": "create-react-app", - "version": "1.5.1", + "version": "1.5.2", "keywords": [ "react" ], diff --git a/packages/react-scripts/package.json b/packages/react-scripts/package.json index b8f1006e5b2..94d8e98df6d 100644 --- a/packages/react-scripts/package.json +++ b/packages/react-scripts/package.json @@ -1,6 +1,6 @@ { "name": "react-scripts", - "version": "1.1.0", + "version": "1.1.1", "description": "Configuration and scripts for Create React App.", "repository": "facebookincubator/create-react-app", "license": "MIT", From c6375edc079a71bd9addd50c58441cbca8839945 Mon Sep 17 00:00:00 2001 From: Lee Byron Date: Thu, 22 Mar 2018 07:27:23 -0700 Subject: [PATCH 11/13] `.mjs` should not resolve before .js files (#4085) Support for .mjs files added in #3239 did not account for npm libraries which ship native mjs files alongside js files. This accounts for this by ensuring .js files resolve before their accompanying .mjs file. Note that this is not an ideal end state since selecting a .mjs over a .js extension should be the result of whether `import` was used instead of `require()` in a node environment with native ESM support (currently via `--experimental-modules`). Instead, this change just *always* selects a .js extension before the .mjs extension if it exists. This unbreaks support for using GraphQL (relay, apollo, etc) within create-react-app projects. --- packages/react-scripts/scripts/utils/createJestConfig.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react-scripts/scripts/utils/createJestConfig.js b/packages/react-scripts/scripts/utils/createJestConfig.js index b4c2cfa5ea9..4c428004a84 100644 --- a/packages/react-scripts/scripts/utils/createJestConfig.js +++ b/packages/react-scripts/scripts/utils/createJestConfig.js @@ -45,12 +45,12 @@ module.exports = (resolve, rootDir, isEjecting) => { }, moduleFileExtensions: [ 'web.js', - 'mjs', 'js', 'json', 'web.jsx', 'jsx', 'node', + 'mjs', ], }; if (rootDir) { From cb1608b3e02e0eef5fd350f6e4cf5ce32bdfc215 Mon Sep 17 00:00:00 2001 From: Vicente Plata Date: Fri, 23 Mar 2018 03:07:25 -0700 Subject: [PATCH 12/13] Add troubleshooting for Github Pages (#4197) Add troubleshooting for an issue that has to do with either 2FA, or using Windows, or both, when trying to deploy an app via gh-pages --- packages/react-scripts/template/README.md | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/packages/react-scripts/template/README.md b/packages/react-scripts/template/README.md index d40c87ebc81..479d632a5f0 100644 --- a/packages/react-scripts/template/README.md +++ b/packages/react-scripts/template/README.md @@ -2209,6 +2209,16 @@ GitHub Pages doesn’t support routers that use the HTML5 `pushState` history AP * You could switch from using HTML5 history API to routing with hashes. If you use React Router, you can switch to `hashHistory` for this effect, but the URL will be longer and more verbose (for example, `http://user.github.io/todomvc/#/todos/42?_k=yknaj`). [Read more](https://reacttraining.com/react-router/web/api/Router) about different history implementations in React Router. * Alternatively, you can use a trick to teach GitHub Pages to handle 404 by redirecting to your `index.html` page with a special redirect parameter. You would need to add a `404.html` file with the redirection code to the `build` folder before deploying your project, and you’ll need to add code handling the redirect parameter to `index.html`. You can find a detailed explanation of this technique [in this guide](https://github.com/rafrex/spa-github-pages). +#### Troubleshooting + +##### "/dev/tty: No such a device or address" + +If, when deploying, you get `/dev/tty: No such a device or address` or a similar error, try the follwing: + +1. Create a new [Personal Access Token](https://github.com/settings/tokens) +2. `git remote set-url origin https://:@github.com//` . +3. Try `npm run deploy again` + ### [Heroku](https://www.heroku.com/) Use the [Heroku Buildpack for Create React App](https://github.com/mars/create-react-app-buildpack).
From a0d5c091c6802306746b61dccb2fbb6333fad5ba Mon Sep 17 00:00:00 2001 From: Kevin Busby Date: Tue, 27 Mar 2018 00:24:13 +0100 Subject: [PATCH 13/13] Tiny typo in comment This is just to correct the typo "Lets check" in a comment to "Let's check". --- packages/react-scripts/template/src/registerServiceWorker.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react-scripts/template/src/registerServiceWorker.js b/packages/react-scripts/template/src/registerServiceWorker.js index a3e6c0cfc10..32731bd0030 100644 --- a/packages/react-scripts/template/src/registerServiceWorker.js +++ b/packages/react-scripts/template/src/registerServiceWorker.js @@ -33,7 +33,7 @@ export default function register() { const swUrl = `${process.env.PUBLIC_URL}/service-worker.js`; if (isLocalhost) { - // This is running on localhost. Lets check if a service worker still exists or not. + // This is running on localhost. Let's check if a service worker still exists or not. checkValidServiceWorker(swUrl); // Add some additional logging to localhost, pointing developers to the