From 58fad404cd33766ee2cf2e263af0144c69dd4ec1 Mon Sep 17 00:00:00 2001 From: Alex Guerra Date: Tue, 16 Jul 2019 15:00:50 -0500 Subject: [PATCH] Update url-loader to 2.0.1 This closes #7359 by making IMAGE_INLINE_SIZE_LIMIT=0 actually disable image inlining. We use url-loader's `limit` option to set the line at which images will be inlined, and we basically expose this option to our end users via the IMAGE_INLINE_SIZE_LIMIT environment variable. Most people using it want to disable inlining images all together (the major motivator for adding it at all was I think for strict CSP), and our documentation said setting the value to zero would do that. However, it did the opposite: url-loader treated zero as "no limit". The update to 2.x fixes this; zero means nothing gets inlined. The other changes from the version bump shouldn't affect us: - minimum node version is 8.9.x, we already require 8.10.x - the limit was "greater than", is now "greater than or equal to" --- packages/react-scripts/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react-scripts/package.json b/packages/react-scripts/package.json index 7d4a3a0c43c..3586204650a 100644 --- a/packages/react-scripts/package.json +++ b/packages/react-scripts/package.json @@ -75,7 +75,7 @@ "style-loader": "0.23.1", "terser-webpack-plugin": "1.2.3", "ts-pnp": "1.1.2", - "url-loader": "1.1.2", + "url-loader": "2.0.1", "webpack": "4.35.0", "webpack-dev-server": "3.2.1", "webpack-manifest-plugin": "2.0.4",