From fea44de0b54b7d155d0379125378cc72786d884a Mon Sep 17 00:00:00 2001 From: Tharun Date: Sun, 13 Oct 2019 14:42:31 +0530 Subject: [PATCH 1/8] Added support for numeric supporters by using babel --- packages/babel-preset-react-app/create.js | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/packages/babel-preset-react-app/create.js b/packages/babel-preset-react-app/create.js index 88e345db08..180c4ddb84 100644 --- a/packages/babel-preset-react-app/create.js +++ b/packages/babel-preset-react-app/create.js @@ -145,6 +145,10 @@ module.exports = function(api, opts, env) { require('@babel/plugin-proposal-decorators').default, false, ], + // Adds Numeric Seperators for TypeScript files + isTypeScriptEnabled && [ + require('@babel/plugin-proposal-numeric-separator'), + ], // class { handleClick = () => { } } // Enable loose mode to use assignment instead of defineProperty // See discussion in https://github.com/facebook/create-react-app/issues/4263 From e5e77685c95791356c8795e0fc9c3f37415b47c8 Mon Sep 17 00:00:00 2001 From: Tharun Date: Sun, 13 Oct 2019 14:42:53 +0530 Subject: [PATCH 2/8] Fixed linting issues --- packages/react-dev-utils/browsersHelper.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react-dev-utils/browsersHelper.js b/packages/react-dev-utils/browsersHelper.js index fdfa6ff317..6d90ffc62a 100644 --- a/packages/react-dev-utils/browsersHelper.js +++ b/packages/react-dev-utils/browsersHelper.js @@ -42,7 +42,7 @@ function shouldSetBrowsers(isInteractive) { } function checkBrowsers(dir, isInteractive, retry = true) { - const current = browserslist.loadConfig({path: dir}); + const current = browserslist.loadConfig({ path: dir }); if (current != null) { return Promise.resolve(current); } From 7d5f89c747eca94631e1b5db2481ee4525d77980 Mon Sep 17 00:00:00 2001 From: Tharun Date: Sun, 13 Oct 2019 14:49:47 +0530 Subject: [PATCH 3/8] Added package for numeric separators in package.json --- packages/babel-preset-react-app/package.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/babel-preset-react-app/package.json b/packages/babel-preset-react-app/package.json index f5c17b0d8b..5c7df8bd76 100644 --- a/packages/babel-preset-react-app/package.json +++ b/packages/babel-preset-react-app/package.json @@ -36,6 +36,7 @@ "@babel/runtime": "7.6.0", "babel-plugin-dynamic-import-node": "2.3.0", "babel-plugin-macros": "2.6.1", - "babel-plugin-transform-react-remove-prop-types": "0.4.24" + "babel-plugin-transform-react-remove-prop-types": "0.4.24", + "@babel/plugin-proposal-numeric-separator": "7.2.0" } } From 4f4154154a77a73c2beceb1c20d9bd528e284392 Mon Sep 17 00:00:00 2001 From: Tharun Date: Sun, 13 Oct 2019 15:05:15 +0530 Subject: [PATCH 4/8] Added babel-syntax-jsx for node-10 --- packages/babel-preset-react-app/package.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/babel-preset-react-app/package.json b/packages/babel-preset-react-app/package.json index 5c7df8bd76..f603fa8b47 100644 --- a/packages/babel-preset-react-app/package.json +++ b/packages/babel-preset-react-app/package.json @@ -37,6 +37,7 @@ "babel-plugin-dynamic-import-node": "2.3.0", "babel-plugin-macros": "2.6.1", "babel-plugin-transform-react-remove-prop-types": "0.4.24", - "@babel/plugin-proposal-numeric-separator": "7.2.0" + "@babel/plugin-proposal-numeric-separator": "7.2.0", + "@babel/plugin-syntax-jsx": "7.2.0" } } From 011ab19d3d20f35985b5619f1b7a22b1a29c6080 Mon Sep 17 00:00:00 2001 From: Tharun Date: Thu, 17 Oct 2019 09:15:59 +0530 Subject: [PATCH 5/8] Added numeric seperators support for all files --- packages/babel-preset-react-app/create.js | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/packages/babel-preset-react-app/create.js b/packages/babel-preset-react-app/create.js index 180c4ddb84..c3203691a1 100644 --- a/packages/babel-preset-react-app/create.js +++ b/packages/babel-preset-react-app/create.js @@ -145,10 +145,8 @@ module.exports = function(api, opts, env) { require('@babel/plugin-proposal-decorators').default, false, ], - // Adds Numeric Seperators for TypeScript files - isTypeScriptEnabled && [ - require('@babel/plugin-proposal-numeric-separator'), - ], + // Adds Numeric Seperators + [require('@babel/plugin-proposal-numeric-separator')], // class { handleClick = () => { } } // Enable loose mode to use assignment instead of defineProperty // See discussion in https://github.com/facebook/create-react-app/issues/4263 From 22c56c4d7274262dc7e1a94603191d87a54d007c Mon Sep 17 00:00:00 2001 From: Tharun Date: Thu, 17 Oct 2019 09:16:44 +0530 Subject: [PATCH 6/8] alphabatically organized package.json --- packages/babel-preset-react-app/package.json | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/packages/babel-preset-react-app/package.json b/packages/babel-preset-react-app/package.json index f603fa8b47..cf5e3271c7 100644 --- a/packages/babel-preset-react-app/package.json +++ b/packages/babel-preset-react-app/package.json @@ -25,6 +25,7 @@ "@babel/plugin-proposal-class-properties": "7.5.5", "@babel/plugin-proposal-decorators": "7.6.0", "@babel/plugin-proposal-object-rest-spread": "7.5.5", + "@babel/plugin-proposal-numeric-separator": "7.2.0", "@babel/plugin-syntax-dynamic-import": "7.2.0", "@babel/plugin-transform-destructuring": "7.6.0", "@babel/plugin-transform-flow-strip-types": "7.4.4", @@ -36,8 +37,6 @@ "@babel/runtime": "7.6.0", "babel-plugin-dynamic-import-node": "2.3.0", "babel-plugin-macros": "2.6.1", - "babel-plugin-transform-react-remove-prop-types": "0.4.24", - "@babel/plugin-proposal-numeric-separator": "7.2.0", - "@babel/plugin-syntax-jsx": "7.2.0" + "babel-plugin-transform-react-remove-prop-types": "0.4.24" } } From 7c7ca8c038e90fc369ab1dbbdb9f9a86d793557b Mon Sep 17 00:00:00 2001 From: Ian Schmitz Date: Wed, 16 Oct 2019 21:47:04 -0700 Subject: [PATCH 7/8] Update package.json --- packages/babel-preset-react-app/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/babel-preset-react-app/package.json b/packages/babel-preset-react-app/package.json index cf5e3271c7..06f4062ef5 100644 --- a/packages/babel-preset-react-app/package.json +++ b/packages/babel-preset-react-app/package.json @@ -24,8 +24,8 @@ "@babel/core": "7.6.0", "@babel/plugin-proposal-class-properties": "7.5.5", "@babel/plugin-proposal-decorators": "7.6.0", - "@babel/plugin-proposal-object-rest-spread": "7.5.5", "@babel/plugin-proposal-numeric-separator": "7.2.0", + "@babel/plugin-proposal-object-rest-spread": "7.5.5", "@babel/plugin-syntax-dynamic-import": "7.2.0", "@babel/plugin-transform-destructuring": "7.6.0", "@babel/plugin-transform-flow-strip-types": "7.4.4", From 23650bc0234ab6028ee6b2e4d562e69a2f3d237a Mon Sep 17 00:00:00 2001 From: Ian Schmitz Date: Wed, 16 Oct 2019 21:57:16 -0700 Subject: [PATCH 8/8] Be consistent with other plugins --- packages/babel-preset-react-app/create.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/babel-preset-react-app/create.js b/packages/babel-preset-react-app/create.js index c3203691a1..92ba72c660 100644 --- a/packages/babel-preset-react-app/create.js +++ b/packages/babel-preset-react-app/create.js @@ -145,8 +145,6 @@ module.exports = function(api, opts, env) { require('@babel/plugin-proposal-decorators').default, false, ], - // Adds Numeric Seperators - [require('@babel/plugin-proposal-numeric-separator')], // class { handleClick = () => { } } // Enable loose mode to use assignment instead of defineProperty // See discussion in https://github.com/facebook/create-react-app/issues/4263 @@ -156,6 +154,8 @@ module.exports = function(api, opts, env) { loose: true, }, ], + // Adds Numeric Seperators + require('@babel/plugin-proposal-numeric-separator').default, // The following two plugins use Object.assign directly, instead of Babel's // extends helper. Note that this assumes `Object.assign` is available. // { ...todo, completed: true }