Skip to content

[firebase_core] Minor cleanups #502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 26, 2022

Conversation

swift-kim
Copy link
Member

No description provided.

@swift-kim swift-kim force-pushed the update-firebase-core branch from 1d64b1e to 5cb77a1 Compare December 16, 2022 08:03
@swift-kim
Copy link
Member Author

swift-kim commented Dec 16, 2022

I just noticed that there's a common analysis_options.yaml for Firebase Desktop packages. Our policy when implementing third-party plugins is to respect "their" analysis options and copy their analysis_options.yaml to the package root (example). However, as we are eventually going to have multiple FlutterFire plugin implementations in this repo, we could also create a common analysis options file in the repo root just like the plus plugins' case.

So there are three options:

  1. No change ("their" code should follow "our" analysis options when being copied to this repo).
  2. Let each FlutterFire package in this repo have its own analysis_options.yaml and all_lint_rules.yaml files.
  3. Create a common analysis_options_firebase.yaml in the repo root and import it from each FlutterFire package.

I'll go with the first option if you guys don't have a specific idea.

cc @wiertel

@swift-kim swift-kim merged commit 81a670c into flutter-tizen:master Dec 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants