Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit 1b6b609

Browse files
authored
Remove SceneDisplayLag trace event temporarily (#17571)
Working theory is that adding async events with begin times in the past causes the timeline to skip some events. See: flutter/flutter#54095
1 parent c2ffe61 commit 1b6b609

File tree

1 file changed

+0
-27
lines changed

1 file changed

+0
-27
lines changed

shell/common/rasterizer.cc

Lines changed: 0 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -242,7 +242,6 @@ RasterStatus Rasterizer::DoDraw(
242242
}
243243

244244
FrameTiming timing;
245-
const fml::TimePoint frame_target_time = layer_tree->target_time();
246245
timing.Set(FrameTiming::kBuildStart, layer_tree->build_start());
247246
timing.Set(FrameTiming::kBuildFinish, layer_tree->build_finish());
248247
timing.Set(FrameTiming::kRasterStart, fml::TimePoint::Now());
@@ -272,32 +271,6 @@ RasterStatus Rasterizer::DoDraw(
272271
timing.Set(FrameTiming::kRasterFinish, raster_finish_time);
273272
delegate_.OnFrameRasterized(timing);
274273

275-
if (raster_finish_time > frame_target_time) {
276-
fml::TimePoint latest_frame_target_time =
277-
delegate_.GetLatestFrameTargetTime();
278-
const auto frame_budget_millis = delegate_.GetFrameBudget().count();
279-
if (latest_frame_target_time < raster_finish_time) {
280-
latest_frame_target_time =
281-
latest_frame_target_time +
282-
fml::TimeDelta::FromMillisecondsF(frame_budget_millis);
283-
}
284-
const auto frame_lag =
285-
(latest_frame_target_time - frame_target_time).ToMillisecondsF();
286-
const int vsync_transitions_missed = round(frame_lag / frame_budget_millis);
287-
fml::tracing::TraceEventAsyncComplete(
288-
"flutter", // category
289-
"SceneDisplayLag", // name
290-
frame_target_time, // begin_time
291-
raster_finish_time, // end_time
292-
"frame_target_time", // arg_key_1
293-
frame_target_time, // arg_val_1
294-
"current_frame_target_time", // arg_key_2
295-
latest_frame_target_time, // arg_val_2
296-
"vsync_transitions_missed", // arg_key_3
297-
vsync_transitions_missed // arg_val_3
298-
);
299-
}
300-
301274
// Pipeline pressure is applied from a couple of places:
302275
// rasterizer: When there are more items as of the time of Consume.
303276
// animator (via shell): Frame gets produces every vsync.

0 commit comments

Comments
 (0)