Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit 824c7c7

Browse files
committed
Merge pull request #61 from Hixie/vestiges
Remove the vestiges of ActiveDOMObject and EventTargetNames, which I missed in my recent patch
2 parents 07a9241 + 2fbea23 commit 824c7c7

File tree

6 files changed

+1
-11
lines changed

6 files changed

+1
-11
lines changed

sky/engine/bindings/IDLExtendedAttributes.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@
3333
# arbitrary, but that "X" is standard, e.g. [Attr=X], [Attr=Foo].
3434
#
3535

36-
ActiveDOMObject
3736
CachedAttribute=*
3837
CallWith=ScriptState|ScriptArguments|ActiveWindow|FirstWindow|ThisValue
3938
Constructor

sky/engine/bindings/scripts/code_generator_dart.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -168,7 +168,6 @@ def generate_code(self, definitions, interface_name,
168168
interface_global = {'component_dir': interface_info['component_dir'],
169169
'name': template_contents['interface_name'],
170170
'parent_interface': template_contents['parent_interface'],
171-
'is_active_dom_object': template_contents['is_active_dom_object'],
172171
'has_resolver': template_contents['interface_name'],
173172
'native_entries': sorted(template_contents['native_entries'], key=lambda(x): x['blink_entry']),
174173
}

sky/engine/bindings/scripts/compute_interfaces_info_overall.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,6 @@
8484
from utilities import read_pickle_files, write_pickle_file
8585

8686
INHERITED_EXTENDED_ATTRIBUTES = set([
87-
'ActiveDOMObject',
8887
'DependentLifetime',
8988
'NotScriptWrappable',
9089
])

sky/engine/bindings/scripts/v8_interface.py

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -74,9 +74,6 @@ def interface_context(interface):
7474
header_includes.update(v8_types.includes_for_interface(parent_interface))
7575
extended_attributes = interface.extended_attributes
7676

77-
# [ActiveDOMObject]
78-
is_active_dom_object = 'ActiveDOMObject' in extended_attributes
79-
8077
# [DependentLifetime]
8178
is_dependent_lifetime = 'DependentLifetime' in extended_attributes
8279

@@ -134,14 +131,12 @@ def interface_context(interface):
134131
'has_visit_dom_wrapper': has_visit_dom_wrapper,
135132
'header_includes': header_includes,
136133
'interface_name': interface.name,
137-
'is_active_dom_object': is_active_dom_object,
138134
'is_dependent_lifetime': is_dependent_lifetime,
139135
'is_exception': interface.is_exception,
140136
'is_script_wrappable': is_script_wrappable,
141137
'iterator_method': iterator_method,
142138
'lifetime': 'Dependent'
143139
if (has_visit_dom_wrapper or
144-
is_active_dom_object or
145140
is_dependent_lifetime)
146141
else 'Independent',
147142
'parent_interface': parent_interface,

sky/engine/core/css/MediaQueryList.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818
*/
1919

2020
#include "sky/engine/core/css/MediaQueryList.h"
21-
#include "gen/sky/core/EventTargetNames.h"
2221
#include "sky/engine/core/css/MediaList.h"
2322
#include "sky/engine/core/css/MediaQueryEvaluator.h"
2423
#include "sky/engine/core/css/MediaQueryListListener.h"

sky/engine/platform/AsyncMethodRunner.h

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -70,8 +70,7 @@ class AsyncMethodRunner final {
7070
}
7171

7272
// If it's scheduled to run the method, cancel it and remember to schedule
73-
// it again when resume() is called. Mainly for implementing
74-
// ActiveDOMObject::suspend().
73+
// it again when resume() is called.
7574
void suspend()
7675
{
7776
if (m_suspended)

0 commit comments

Comments
 (0)