Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit a70369d

Browse files
authored
Include updated locations for dart third_party components into license ignore-list. (#47770)
Incoming dart roll with https://dart.googlesource.com/sdk/+/4d308f39115a2969fb9908055b37a93969d4fc8d moves `runtime/third_parry` in dart to `third_party`, so license script ignore-list have to be updated to accommodate new location. Once the roll lands, old locations should be cleaned up from the ignore-list.
1 parent a1bad07 commit a70369d

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

ci/licenses_golden/tool_signature

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
1-
Signature: 69d986a7b2275b798b574b6aea2c1b78
1+
Signature: 4b8678841cc9a099770862d08fb15c47
22

tools/licenses/lib/paths.dart

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -96,11 +96,15 @@ final Set<String> skippedPaths = <String>{
9696
r'third_party/dart/pkg', // packages that don't become part of the binary (e.g. the analyzer)
9797
r'third_party/dart/runtime/bin/ffi_test',
9898
r'third_party/dart/runtime/docs',
99-
r'third_party/dart/runtime/third_party/binary_size', // not linked in either
100-
r'third_party/dart/runtime/third_party/d3', // Siva says "that is the charting library used by the binary size tool"
99+
// TODO(aam): remove as a dup
100+
r'third_party/dart/runtime/third_party/binary_size',
101+
// TODO(aam): remove as a dup
102+
r'third_party/dart/runtime/third_party/d3',
101103
r'third_party/dart/runtime/vm/service',
102104
r'third_party/dart/sdk/lib/html/doc',
105+
r'third_party/dart/third_party/binary_size', // not linked in
103106
r'third_party/dart/third_party/binaryen', // not linked in
107+
r'third_party/dart/third_party/d3', // Siva says "that is the charting library used by the binary size tool"
104108
r'third_party/dart/third_party/d8', // testing tool for dart2js
105109
r'third_party/dart/third_party/devtools', // not linked in
106110
r'third_party/dart/third_party/firefox_jsshell', // testing tool for dart2js

0 commit comments

Comments
 (0)