Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit d03b5cf

Browse files
author
Kaushik Iska
committed
Remove SceneDisplayLag trace event temporarily
Working theory is that adding async events with begin times in the past causes the timeline to skip some events. See: flutter/flutter#54095
1 parent 394ac6b commit d03b5cf

File tree

1 file changed

+0
-26
lines changed

1 file changed

+0
-26
lines changed

shell/common/rasterizer.cc

Lines changed: 0 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -272,32 +272,6 @@ RasterStatus Rasterizer::DoDraw(
272272
timing.Set(FrameTiming::kRasterFinish, raster_finish_time);
273273
delegate_.OnFrameRasterized(timing);
274274

275-
if (raster_finish_time > frame_target_time) {
276-
fml::TimePoint latest_frame_target_time =
277-
delegate_.GetLatestFrameTargetTime();
278-
const auto frame_budget_millis = delegate_.GetFrameBudget().count();
279-
if (latest_frame_target_time < raster_finish_time) {
280-
latest_frame_target_time =
281-
latest_frame_target_time +
282-
fml::TimeDelta::FromMillisecondsF(frame_budget_millis);
283-
}
284-
const auto frame_lag =
285-
(latest_frame_target_time - frame_target_time).ToMillisecondsF();
286-
const int vsync_transitions_missed = round(frame_lag / frame_budget_millis);
287-
fml::tracing::TraceEventAsyncComplete(
288-
"flutter", // category
289-
"SceneDisplayLag", // name
290-
frame_target_time, // begin_time
291-
raster_finish_time, // end_time
292-
"frame_target_time", // arg_key_1
293-
frame_target_time, // arg_val_1
294-
"current_frame_target_time", // arg_key_2
295-
latest_frame_target_time, // arg_val_2
296-
"vsync_transitions_missed", // arg_key_3
297-
vsync_transitions_missed // arg_val_3
298-
);
299-
}
300-
301275
// Pipeline pressure is applied from a couple of places:
302276
// rasterizer: When there are more items as of the time of Consume.
303277
// animator (via shell): Frame gets produces every vsync.

0 commit comments

Comments
 (0)