-
Notifications
You must be signed in to change notification settings - Fork 6k
Add comments to build_and_test_linux_unopt_debug #17567
Conversation
Clarify that the test depends on the framework repo. It may fail if the framework repo is broken, so the engine committer don't need to be in panic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if it's possible to also add a comment that's visible in the github UI?
@fkorotkov : how may I add a custom error info to a Cirrus task so it can be shown when it failed? |
@liyuqian there is no such option at the moment. Not sure where it can be displayed 🤔 One thing you can do is to create a separate script after verify_framework_script:
- echo "Checking framework was passing..."
- curl -s https://api.cirrus-ci.com/github/flutter/flutter.json | grep -q passing That way |
Thanks @fkorotkov ! I'll do that. BTW, I have a strange issue: I can't access https://cirrus-ci.com/github/flutter/flutter if I'm logged in, but I can read it from Incognito mode: |
@liyuqian very weird. I can see that GitHub was reporting that you have |
Clarify that the test depends on the framework repo. It may fail if the framework repo is broken, so the engine committer don't need to be in panic.
Clarify that the test depends on the framework repo. It may fail if the framework repo is broken, so the engine committer don't need to be in panic.
This is inspired by the failure in https://github.com/flutter/engine/pull/17538/checks?check_run_id=565790440 , which was caused by the problem mentioned in flutter/flutter#54176.