Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Add comments to build_and_test_linux_unopt_debug #17567

Merged
merged 2 commits into from
Apr 7, 2020

Conversation

liyuqian
Copy link
Contributor

@liyuqian liyuqian commented Apr 7, 2020

Clarify that the test depends on the framework repo. It may fail if the framework repo is broken, so the engine committer don't need to be in panic.

This is inspired by the failure in https://github.com/flutter/engine/pull/17538/checks?check_run_id=565790440 , which was caused by the problem mentioned in flutter/flutter#54176.

Clarify that the test depends on the framework repo. It may fail if the
framework repo is broken, so the engine committer don't need to be in
panic.
@liyuqian liyuqian requested a review from gw280 April 7, 2020 17:44
@auto-assign auto-assign bot requested a review from chinmaygarde April 7, 2020 17:46
Copy link
Contributor

@gw280 gw280 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if it's possible to also add a comment that's visible in the github UI?

@liyuqian
Copy link
Contributor Author

liyuqian commented Apr 7, 2020

@fkorotkov : how may I add a custom error info to a Cirrus task so it can be shown when it failed?

@fkorotkov
Copy link

@liyuqian there is no such option at the moment. Not sure where it can be displayed 🤔

One thing you can do is to create a separate script after fetch_framework_script to validate Cirrus was not failing (passing or building) for the sha:

verify_framework_script:
  - echo "Checking framework was passing..."
  - curl -s https://api.cirrus-ci.com/github/flutter/flutter.json | grep -q passing

That way verify_framework_script will fail if the latest builds on flutter/flutter was failing.

@liyuqian
Copy link
Contributor Author

liyuqian commented Apr 7, 2020

Thanks @fkorotkov ! I'll do that.

BTW, I have a strange issue: I can't access https://cirrus-ci.com/github/flutter/flutter if I'm logged in, but I can read it from Incognito mode:

Screen Shot 2020-04-07 at 11 23 47 AM

@fkorotkov
Copy link

@liyuqian very weird. I can see that GitHub was reporting that you have none permissions for couple of hours for bunch of flutter org repositories which doesn't make sense since they are public. 🤔Will add some logic to elevate permissions for such cases. It should start working soon either when I'll add the logic or when caches will expire and GH will return correct permissions.

@liyuqian liyuqian merged commit 3c1c3e2 into flutter:master Apr 7, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 8, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 8, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 8, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 8, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 8, 2020
@liyuqian liyuqian deleted the comment_test branch April 8, 2020 22:54
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 8, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 9, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 9, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 9, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 9, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 9, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 9, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 10, 2020
goderbauer pushed a commit to goderbauer/engine that referenced this pull request Apr 16, 2020
Clarify that the test depends on the framework repo. It may fail if the
framework repo is broken, so the engine committer don't need to be in
panic.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants