Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Start an engine in ShellTest.OnServiceProtocolGetSkSLsWorks #20801

Closed

Conversation

jason-simmons
Copy link
Member

This test invokes a service protocol handler, and related methods such
as Shell::GetServiceProtocolDescription make the assumption that an
engine is available.

See #20142

This test invokes a service protocol handler, and related methods such
as Shell::GetServiceProtocolDescription make the assumption that an
engine is available.

See flutter#20142
Copy link
Contributor

@liyuqian liyuqian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the quick fix!

@auto-assign auto-assign bot requested a review from gw280 August 26, 2020 22:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants