This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] add non-emulated advanced blend support to experimental canvas #52245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
flar
approved these changes
Apr 19, 2024
|
This does not need DL changes, since for the non-emulated cases we don't need to know anything in advance. Re: test exemptions, I've been sort of passing on that since its off by default |
jonahwilliams
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 19, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 20, 2024
…147095) flutter/engine@55670b7...3db86b3 2024-04-19 [email protected] Roll Dart SDK from 2ff00e4eb759 to d882ce089110 (1 revision) (flutter/engine#52272) 2024-04-19 [email protected] [macOS] Consolidate view management (flutter/engine#52254) 2024-04-19 [email protected] Roll Skia from f4a214ecf197 to 1910252ea26a (3 revisions) (flutter/engine#52269) 2024-04-19 [email protected] [Impeller] add non-emulated advanced blend support to experimental canvas (flutter/engine#52245) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gilnobrega
pushed a commit
to gilnobrega/flutter
that referenced
this pull request
Apr 22, 2024
…lutter#147095) flutter/engine@55670b7...3db86b3 2024-04-19 [email protected] Roll Dart SDK from 2ff00e4eb759 to d882ce089110 (1 revision) (flutter/engine#52272) 2024-04-19 [email protected] [macOS] Consolidate view management (flutter/engine#52254) 2024-04-19 [email protected] Roll Skia from f4a214ecf197 to 1910252ea26a (3 revisions) (flutter/engine#52269) 2024-04-19 [email protected] [Impeller] add non-emulated advanced blend support to experimental canvas (flutter/engine#52245) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for non-emulated advnaced blends (Android Vulkan and iOS devices). Still need to add support for emulation when we do backdrop filters.