Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Impeller] Fix markdown formatting for blocks with tips. #53789

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Conversation

chinmaygarde
Copy link
Member

In the previous patch, I had used the incorrect markdown syntax.

Followup for #53671

In the previous patch, I had used the incorrect markdown syntax.
@chinmaygarde chinmaygarde requested a review from bdero July 9, 2024 23:09
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chinmaygarde chinmaygarde added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 10, 2024
@auto-submit auto-submit bot merged commit db2b45b into main Jul 10, 2024
27 checks passed
@auto-submit auto-submit bot deleted the bad_tips branch July 10, 2024 05:40
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jul 10, 2024
…151522)

flutter/engine@371db85...db2b45b

2024-07-10 [email protected] [Impeller] Fix markdown formatting for blocks with tips. (flutter/engine#53789)
2024-07-10 98614782+auto-submit[bot]@users.noreply.github.com Reverts "dart:ui - drop deprecated hash functions (#53787)" (flutter/engine#53794)
2024-07-10 98614782+auto-submit[bot]@users.noreply.github.com Reverts "web_ui: drop internal hash code library (#53783)" (flutter/engine#53793)
2024-07-10 [email protected] Manual roll Dart SDK from ffc8bb004a64 to dba0dfbd06eb (23 revisions) (flutter/engine#53791)
2024-07-10 [email protected] Impeller really wants premultiplied alpha (flutter/engine#53770)
2024-07-09 [email protected] dart:ui - drop deprecated hash functions (flutter/engine#53787)
2024-07-09 [email protected] [Impeller] Validation errors in tests cause GTest failures. (flutter/engine#53786)
2024-07-09 [email protected] [Impeller] Update docs that specify how to select the Impeller backend. (flutter/engine#53788)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
autosubmit Merge PR when tree becomes green via auto submit App e: impeller
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants