Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Impeller] Use depth transform in framebuffer blend entities. #53951

Merged
merged 2 commits into from
Jul 16, 2024

Conversation

bdero
Copy link
Member

@bdero bdero commented Jul 16, 2024

\Without this the depth always ends up being a very large z depth of 0.5, which can cause clips to be ignored.

Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@flutter-dashboard
Copy link

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

Changes reported for pull request #53951 at sha 906ac11

@bdero bdero added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 16, 2024
@auto-submit auto-submit bot merged commit b2bdd68 into flutter:main Jul 16, 2024
32 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 17, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jul 17, 2024
…ions) (#151868)

Manual roll requested by [email protected]

flutter/engine@5b9fc4e...b2bdd68

2024-07-16 [email protected] [Impeller] Use depth transform in framebuffer blend entities. (flutter/engine#53951)
2024-07-16 [email protected] [macOS] Eliminate archive_gen_snapshot target (flutter/engine#53948)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TytaniumDev pushed a commit to TytaniumDev/flutter that referenced this pull request Aug 7, 2024
…ions) (flutter#151868)

Manual roll requested by [email protected]

flutter/engine@5b9fc4e...b2bdd68

2024-07-16 [email protected] [Impeller] Use depth transform in framebuffer blend entities. (flutter/engine#53951)
2024-07-16 [email protected] [macOS] Eliminate archive_gen_snapshot target (flutter/engine#53948)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
jonahwilliams pushed a commit to jonahwilliams/engine that referenced this pull request Aug 9, 2024
…r#53951)

\Without this the depth always ends up being a very large z depth of 0.5, which can cause clips to be ignored.
auto-submit bot pushed a commit that referenced this pull request Aug 13, 2024
…3951) (#54478)

\Without this the depth always ends up being a very large z depth of 0.5, which can cause clips to be ignored.
Buchimi pushed a commit to Buchimi/flutter that referenced this pull request Sep 2, 2024
…ions) (flutter#151868)

Manual roll requested by [email protected]

flutter/engine@5b9fc4e...b2bdd68

2024-07-16 [email protected] [Impeller] Use depth transform in framebuffer blend entities. (flutter/engine#53951)
2024-07-16 [email protected] [macOS] Eliminate archive_gen_snapshot target (flutter/engine#53948)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
autosubmit Merge PR when tree becomes green via auto submit App e: impeller will affect goldens
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants