From 2fbea232de0a857d390320a951e0253331fb47f9 Mon Sep 17 00:00:00 2001 From: Hixie Date: Thu, 16 Jul 2015 15:42:00 -0700 Subject: [PATCH] Remove the vestiges of ActiveDOMObject and EventTargetNames, which I missed in my recent patch. --- sky/engine/bindings/IDLExtendedAttributes.txt | 1 - sky/engine/bindings/scripts/code_generator_dart.py | 1 - .../bindings/scripts/compute_interfaces_info_overall.py | 1 - sky/engine/bindings/scripts/v8_interface.py | 5 ----- sky/engine/core/css/MediaQueryList.cpp | 1 - sky/engine/platform/AsyncMethodRunner.h | 3 +-- 6 files changed, 1 insertion(+), 11 deletions(-) diff --git a/sky/engine/bindings/IDLExtendedAttributes.txt b/sky/engine/bindings/IDLExtendedAttributes.txt index 6717f24d76966..8d9914b9e95c1 100644 --- a/sky/engine/bindings/IDLExtendedAttributes.txt +++ b/sky/engine/bindings/IDLExtendedAttributes.txt @@ -33,7 +33,6 @@ # arbitrary, but that "X" is standard, e.g. [Attr=X], [Attr=Foo]. # -ActiveDOMObject CachedAttribute=* CallWith=ScriptState|ScriptArguments|ActiveWindow|FirstWindow|ThisValue Constructor diff --git a/sky/engine/bindings/scripts/code_generator_dart.py b/sky/engine/bindings/scripts/code_generator_dart.py index c666d0b756c83..45827f527672d 100644 --- a/sky/engine/bindings/scripts/code_generator_dart.py +++ b/sky/engine/bindings/scripts/code_generator_dart.py @@ -168,7 +168,6 @@ def generate_code(self, definitions, interface_name, interface_global = {'component_dir': interface_info['component_dir'], 'name': template_contents['interface_name'], 'parent_interface': template_contents['parent_interface'], - 'is_active_dom_object': template_contents['is_active_dom_object'], 'has_resolver': template_contents['interface_name'], 'native_entries': sorted(template_contents['native_entries'], key=lambda(x): x['blink_entry']), } diff --git a/sky/engine/bindings/scripts/compute_interfaces_info_overall.py b/sky/engine/bindings/scripts/compute_interfaces_info_overall.py index 0482dddeb3e45..9c321d993980b 100755 --- a/sky/engine/bindings/scripts/compute_interfaces_info_overall.py +++ b/sky/engine/bindings/scripts/compute_interfaces_info_overall.py @@ -84,7 +84,6 @@ from utilities import read_pickle_files, write_pickle_file INHERITED_EXTENDED_ATTRIBUTES = set([ - 'ActiveDOMObject', 'DependentLifetime', 'NotScriptWrappable', ]) diff --git a/sky/engine/bindings/scripts/v8_interface.py b/sky/engine/bindings/scripts/v8_interface.py index 7bb6c840fb3de..442cc56b2a84c 100644 --- a/sky/engine/bindings/scripts/v8_interface.py +++ b/sky/engine/bindings/scripts/v8_interface.py @@ -74,9 +74,6 @@ def interface_context(interface): header_includes.update(v8_types.includes_for_interface(parent_interface)) extended_attributes = interface.extended_attributes - # [ActiveDOMObject] - is_active_dom_object = 'ActiveDOMObject' in extended_attributes - # [DependentLifetime] is_dependent_lifetime = 'DependentLifetime' in extended_attributes @@ -134,14 +131,12 @@ def interface_context(interface): 'has_visit_dom_wrapper': has_visit_dom_wrapper, 'header_includes': header_includes, 'interface_name': interface.name, - 'is_active_dom_object': is_active_dom_object, 'is_dependent_lifetime': is_dependent_lifetime, 'is_exception': interface.is_exception, 'is_script_wrappable': is_script_wrappable, 'iterator_method': iterator_method, 'lifetime': 'Dependent' if (has_visit_dom_wrapper or - is_active_dom_object or is_dependent_lifetime) else 'Independent', 'parent_interface': parent_interface, diff --git a/sky/engine/core/css/MediaQueryList.cpp b/sky/engine/core/css/MediaQueryList.cpp index 891559540c2af..e8744e322a015 100644 --- a/sky/engine/core/css/MediaQueryList.cpp +++ b/sky/engine/core/css/MediaQueryList.cpp @@ -18,7 +18,6 @@ */ #include "sky/engine/core/css/MediaQueryList.h" -#include "gen/sky/core/EventTargetNames.h" #include "sky/engine/core/css/MediaList.h" #include "sky/engine/core/css/MediaQueryEvaluator.h" #include "sky/engine/core/css/MediaQueryListListener.h" diff --git a/sky/engine/platform/AsyncMethodRunner.h b/sky/engine/platform/AsyncMethodRunner.h index 79ee9d3aa7fa8..48623f610b122 100644 --- a/sky/engine/platform/AsyncMethodRunner.h +++ b/sky/engine/platform/AsyncMethodRunner.h @@ -70,8 +70,7 @@ class AsyncMethodRunner final { } // If it's scheduled to run the method, cancel it and remember to schedule - // it again when resume() is called. Mainly for implementing - // ActiveDOMObject::suspend(). + // it again when resume() is called. void suspend() { if (m_suspended)