This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Rename macOS FLEPlugin* to FlutterPlugin* #9074
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As another step toward aligning the macOS plugin API with the iOS plugin API, and with its final form, rename the plugin-related classes from FLEPlugin* to FlutterPlugin*. This makes the names of the clasess the same between iOS and macOS. Eventually they should actually merge, with annotations/ifdefs for platform differences, but for now since the macOS version uses the same method names and is simply a subset of the iOS APIs (with one to-be-stabilized method that is macOS-specific) doing the merge later won't be a breaking change. Doing this now allows for building out plugin tooling and plugin implementations on macOS without creating a growing body of code that will experience a breaking change later. See: flutter/flutter#31735 flutter/flutter#32718
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 26, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 26, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 27, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 27, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 27, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 27, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 28, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 28, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 28, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 28, 2019
This was referenced May 28, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 28, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 28, 2019
This was referenced May 28, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 28, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 28, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 28, 2019
This was referenced May 28, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 28, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 29, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 29, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 29, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 29, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 29, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 29, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 30, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 30, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
May 30, 2019
flutter/engine@8dc3a4c...4c4c0f8 git log 8dc3a4c..4c4c0f8 --no-merges --oneline 4c4c0f8 Add plugin shim to facilitate old plugins in new embedding (#33478). (flutter/engine#9120) e8c2b17 Added support for transparent FlutterActivitys (#32740). (flutter/engine#9115) 19c5029 Roll src/third_party/skia 29e013deb476..1013ecfb3421 (3 commits) (flutter/engine#9130) 45d39e1 Revert "Roll src/third_party/dart fee615c5a5..d5405d06f4 (21 commits) (#9127)" (flutter/engine#9135) 44f1b44 Revert "Use track-widget-creation transformer included in the sdk. (#9085)" (flutter/engine#9134) ae14c5a Roll src/third_party/dart fee615c5a5..d5405d06f4 (21 commits) (flutter/engine#9127) 3ea7ac8 Roll src/third_party/skia 633db4db7672..29e013deb476 (3 commits) (flutter/engine#9128) 8ad0e2f Roll src/third_party/skia 25b63f91b3b4..633db4db7672 (4 commits) (flutter/engine#9125) 37e6e0c Roll src/third_party/skia 8f88b2da05d5..25b63f91b3b4 (2 commits) (flutter/engine#9121) 37b367e Allow specifying both Dart and non-Dart fixtures in engine unit-tests. (flutter/engine#9113) 28f2c05 Roll src/third_party/skia 1f02e8488551..8f88b2da05d5 (3 commits) (flutter/engine#9116) 0932008 Remove outdated TODOs (flutter/engine#9114) c880ca2 Roll src/third_party/dart 50b0d85804..fee615c5a5 (4 commits) 6e51513 Removing unused imports (flutter/engine#9108) 9ee2697 Roll src/third_party/skia d04aaa3a841a..1f02e8488551 (8 commits) (flutter/engine#9109) fa2e2d9 Add checks to constructors and add missing constructor members (flutter/engine#9106) 7e1788a Fix unopt variants of profile and release builds. (flutter/engine#9107) 867120c Better help message. (flutter/engine#9097) e27c6e8 Forward custom IDE flags to GN. (flutter/engine#9023) 6b4ca8d Roll src/third_party/skia 176b214f91bc..d04aaa3a841a (7 commits) (flutter/engine#9105) a207318 Roll src/third_party/dart ec4d48e241..50b0d85804 (87 commits) 0a6aeb3 Roll src/third_party/skia 213aa46af167..176b214f91bc (2 commits) (flutter/engine#9100) f2e22aa Roll src/third_party/skia 7730d7cb8fb2..213aa46af167 (3 commits) (flutter/engine#9098) 557db42 Roll src/third_party/skia de7e074e8190..7730d7cb8fb2 (2 commits) (flutter/engine#9096) 64a4a0e Roll src/third_party/skia f06b6d5469a5..de7e074e8190 (1 commits) (flutter/engine#9094) fdee625 Roll src/third_party/skia 7e5a64f517e4..f06b6d5469a5 (2 commits) (flutter/engine#9093) daf47f0 Roll src/third_party/skia dc01a84ae098..7e5a64f517e4 (1 commits) (flutter/engine#9092) 41e10f0 Fix internal break since listing contents can return null (flutter/engine#9078) cf1b203 Roll src/third_party/skia f33c95cd6f55..dc01a84ae098 (3 commits) (flutter/engine#9091) 2404cdc Rename macOS FLEPlugin* to FlutterPlugin* (flutter/engine#9074) 509a43f Apply minor cleanups to Android embedding (flutter/engine#9088) 0a0f330 Removed outdated deprecation comments (flutter/engine#9087) a44cbbf Delete BSDiff sources (flutter/engine#9086) 0f1ff3b Correct typos, adopt US spellings (flutter/engine#9081) 651c904 Use track-widget-creation transformer included in the sdk. (flutter/engine#9085) cfa524f New Plugin API PR4: Adds Lifecycle support to the new plugin system. (flutter/engine#9049) 6b8ac18 Roll src/third_party/skia d9430297e74a..f33c95cd6f55 (5 commits) (flutter/engine#9082) 11408ef Update macOS podspec version requirement (flutter/engine#9077) 66c6ae4 Roll src/third_party/skia a4b837971c4b..d9430297e74a (30 commits) (flutter/engine#9080) 9151b37 Roll src/third_party/skia 9339a8a61af0..a4b837971c4b (34 commits) (flutter/engine#9076) ee6a9c4 Fix unchecked operation warnings in FlutterMain (flutter/engine#9073) 333042c Roll third_party/dart/tools/sdks to 2.3.0 (flutter/engine#9072) 01b8c07 Roll src/third_party/skia f77dbd04b926..9339a8a61af0 (12 commits) (flutter/engine#9065) 26b4fb5 Roll src/third_party/dart e3edfd36b2..ec4d48e241 (7 commits) 9d2d58a Add mouse button support to the macOS shell (flutter/engine#9054) ...
huqiuser
pushed a commit
to huqiuser/engine
that referenced
this pull request
Jun 12, 2019
As another step toward aligning the macOS plugin API with the iOS plugin API, and with its final form, rename the plugin-related classes from FLEPlugin* to FlutterPlugin*. This makes the names of the clasess the same between iOS and macOS. Eventually they should actually merge, with annotations/ifdefs for platform differences, but for now since the macOS version uses the same method names and is simply a subset of the iOS APIs (with one to-be-stabilized method that is macOS-specific) doing the merge later won't be a breaking change. Doing this now allows for building out plugin tooling and plugin implementations on macOS without creating a growing body of code that will experience a breaking change later. See: flutter/flutter#31735 flutter/flutter#32718
kiku-jw
pushed a commit
to kiku-jw/flutter
that referenced
this pull request
Jun 14, 2019
flutter/engine@8dc3a4c...4c4c0f8 git log 8dc3a4c..4c4c0f8 --no-merges --oneline 4c4c0f8 Add plugin shim to facilitate old plugins in new embedding (flutter#33478). (flutter/engine#9120) e8c2b17 Added support for transparent FlutterActivitys (flutter#32740). (flutter/engine#9115) 19c5029 Roll src/third_party/skia 29e013deb476..1013ecfb3421 (3 commits) (flutter/engine#9130) 45d39e1 Revert &flutter#34;Roll src/third_party/dart fee615c5a5..d5405d06f4 (21 commits) (flutter#9127)&flutter#34; (flutter/engine#9135) 44f1b44 Revert &flutter#34;Use track-widget-creation transformer included in the sdk. (flutter#9085)&flutter#34; (flutter/engine#9134) ae14c5a Roll src/third_party/dart fee615c5a5..d5405d06f4 (21 commits) (flutter/engine#9127) 3ea7ac8 Roll src/third_party/skia 633db4db7672..29e013deb476 (3 commits) (flutter/engine#9128) 8ad0e2f Roll src/third_party/skia 25b63f91b3b4..633db4db7672 (4 commits) (flutter/engine#9125) 37e6e0c Roll src/third_party/skia 8f88b2da05d5..25b63f91b3b4 (2 commits) (flutter/engine#9121) 37b367e Allow specifying both Dart and non-Dart fixtures in engine unit-tests. (flutter/engine#9113) 28f2c05 Roll src/third_party/skia 1f02e8488551..8f88b2da05d5 (3 commits) (flutter/engine#9116) 0932008 Remove outdated TODOs (flutter/engine#9114) c880ca2 Roll src/third_party/dart 50b0d85804..fee615c5a5 (4 commits) 6e51513 Removing unused imports (flutter/engine#9108) 9ee2697 Roll src/third_party/skia d04aaa3a841a..1f02e8488551 (8 commits) (flutter/engine#9109) fa2e2d9 Add checks to constructors and add missing constructor members (flutter/engine#9106) 7e1788a Fix unopt variants of profile and release builds. (flutter/engine#9107) 867120c Better help message. (flutter/engine#9097) e27c6e8 Forward custom IDE flags to GN. (flutter/engine#9023) 6b4ca8d Roll src/third_party/skia 176b214f91bc..d04aaa3a841a (7 commits) (flutter/engine#9105) a207318 Roll src/third_party/dart ec4d48e241..50b0d85804 (87 commits) 0a6aeb3 Roll src/third_party/skia 213aa46af167..176b214f91bc (2 commits) (flutter/engine#9100) f2e22aa Roll src/third_party/skia 7730d7cb8fb2..213aa46af167 (3 commits) (flutter/engine#9098) 557db42 Roll src/third_party/skia de7e074e8190..7730d7cb8fb2 (2 commits) (flutter/engine#9096) 64a4a0e Roll src/third_party/skia f06b6d5469a5..de7e074e8190 (1 commits) (flutter/engine#9094) fdee625 Roll src/third_party/skia 7e5a64f517e4..f06b6d5469a5 (2 commits) (flutter/engine#9093) daf47f0 Roll src/third_party/skia dc01a84ae098..7e5a64f517e4 (1 commits) (flutter/engine#9092) 41e10f0 Fix internal break since listing contents can return null (flutter/engine#9078) cf1b203 Roll src/third_party/skia f33c95cd6f55..dc01a84ae098 (3 commits) (flutter/engine#9091) 2404cdc Rename macOS FLEPlugin* to FlutterPlugin* (flutter/engine#9074) 509a43f Apply minor cleanups to Android embedding (flutter/engine#9088) 0a0f330 Removed outdated deprecation comments (flutter/engine#9087) a44cbbf Delete BSDiff sources (flutter/engine#9086) 0f1ff3b Correct typos, adopt US spellings (flutter/engine#9081) 651c904 Use track-widget-creation transformer included in the sdk. (flutter/engine#9085) cfa524f New Plugin API PR4: Adds Lifecycle support to the new plugin system. (flutter/engine#9049) 6b8ac18 Roll src/third_party/skia d9430297e74a..f33c95cd6f55 (5 commits) (flutter/engine#9082) 11408ef Update macOS podspec version requirement (flutter/engine#9077) 66c6ae4 Roll src/third_party/skia a4b837971c4b..d9430297e74a (30 commits) (flutter/engine#9080) 9151b37 Roll src/third_party/skia 9339a8a61af0..a4b837971c4b (34 commits) (flutter/engine#9076) ee6a9c4 Fix unchecked operation warnings in FlutterMain (flutter/engine#9073) 333042c Roll third_party/dart/tools/sdks to 2.3.0 (flutter/engine#9072) 01b8c07 Roll src/third_party/skia f77dbd04b926..9339a8a61af0 (12 commits) (flutter/engine#9065) 26b4fb5 Roll src/third_party/dart e3edfd36b2..ec4d48e241 (7 commits) 9d2d58a Add mouse button support to the macOS shell (flutter/engine#9054) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As another step toward aligning the macOS plugin API with the iOS plugin
API, and with its final form, rename the plugin-related classes from
FLEPlugin* to FlutterPlugin*. This makes the names of the clasess the
same between iOS and macOS. Eventually they should actually merge, with
annotations/ifdefs for platform differences, but for now since the macOS
version uses the same method names and is simply a subset of the iOS
APIs (with one to-be-stabilized method that is macOS-specific) doing the
merge later won't be a breaking change.
Doing this now allows for building out plugin tooling and plugin
implementations on macOS without creating a growing body of code that
will experience a breaking change later.
See:
flutter/flutter#31735
flutter/flutter#32718