Removed superfluous copy in license checker #167146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
github-actions
bot
added
the
engine
matanlurey
approved these changes
Apr 14, 2025
gaaclarke
added
the
autosubmit
|
autosubmit label was removed for flutter/flutter/167146, because - The status or check suite Linux linux_license has failed. Please fix the issues identified (or deflake) before re-applying this label. |
auto-submit
bot
removed
the
autosubmit
gaaclarke
force-pushed
the
remove-checker-copy
branch
from
a0618da to
1059743
Compare
gaaclarke
force-pushed
the
remove-checker-copy
branch
from
7604de0 to
3c5f732
Compare
gaaclarke
added
the
autosubmit
flutter-dashboard
bot
removed
the
autosubmit
|
I removed this from the queue as it was stuck and blocking other PRs. This is not your fault and looks to be infra. We'll re-insert you into the queue. |
jason-simmons
added a commit
to jason-simmons/flutter
that referenced
this pull request
Apr 16, 2025
This reverts commit b4dc233. The license script provides a RegExp wrapper that tracks the cost of the script's regexes. Dart's RegExp.allMatches returns an Iterable whose iterators lazily execute the regex. Calling toList will execute the regex on the entire input within allMatches, allowing measurement of the regex's cost. Returning the Iterable will instead shift the execution cost to the caller. Also, in local measurements I'm seeing significantly better performance from finding all of the matches immediately with toList versus having the caller use the lazy iterator.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 16, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 16, 2025
mboetger
pushed a commit
to mboetger/flutter
that referenced
this pull request
Apr 16, 2025
This was the most expensive part of finding the files phase. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Apr 16, 2025
flutter/flutter@db68c95...aef4718 2025-04-16 [email protected] [Web] Remove `webOnlyUniformRadii` from `RRect` (flutter/flutter#167237) 2025-04-16 [email protected] Roll Skia from 76cb5d4fba27 to 6627deb65939 (10 revisions) (flutter/flutter#167249) 2025-04-16 [email protected] Adding macrobenchmarks for DDC (flutter/flutter#166617) 2025-04-15 [email protected] Add button icon support for animation duration (flutter/flutter#162667) 2025-04-15 [email protected] Roll Dartdoc to 8.3.3 (flutter/flutter#167231) 2025-04-15 [email protected] Removed superfluous copy in license checker (flutter/flutter#167146) 2025-04-15 [email protected] license checker: ignore git sha in dart license (flutter/flutter#167153) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
fluttermirroringbot
pushed a commit
that referenced
this pull request
Apr 16, 2025
This reverts commit b4dc233. The license script provides a RegExp wrapper that tracks the cost of the script's regexes. Dart's RegExp.allMatches returns an Iterable whose iterators lazily execute the regex. Calling toList will execute the regex on the entire input within allMatches, allowing measurement of the regex's cost. Returning the Iterable will instead shift the execution cost to the caller. Also, in local measurements I'm seeing significantly better performance from finding all of the matches immediately with toList versus having the caller use the lazy iterator.
ash2moon
pushed a commit
to ash2moon/flutter
that referenced
this pull request
Apr 21, 2025
This was the most expensive part of finding the files phase. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
ash2moon
pushed a commit
to ash2moon/flutter
that referenced
this pull request
Apr 21, 2025
…flutter#167246) This reverts commit b4dc233. The license script provides a RegExp wrapper that tracks the cost of the script's regexes. Dart's RegExp.allMatches returns an Iterable whose iterators lazily execute the regex. Calling toList will execute the regex on the entire input within allMatches, allowing measurement of the regex's cost. Returning the Iterable will instead shift the execution cost to the caller. Also, in local measurements I'm seeing significantly better performance from finding all of the matches immediately with toList versus having the caller use the lazy iterator.
CodixNinja
pushed a commit
to CodixNinja/packages
that referenced
this pull request
May 15, 2025
flutter/flutter@db68c95...aef4718 2025-04-16 [email protected] [Web] Remove `webOnlyUniformRadii` from `RRect` (flutter/flutter#167237) 2025-04-16 [email protected] Roll Skia from 76cb5d4fba27 to 6627deb65939 (10 revisions) (flutter/flutter#167249) 2025-04-16 [email protected] Adding macrobenchmarks for DDC (flutter/flutter#166617) 2025-04-15 [email protected] Add button icon support for animation duration (flutter/flutter#162667) 2025-04-15 [email protected] Roll Dartdoc to 8.3.3 (flutter/flutter#167231) 2025-04-15 [email protected] Removed superfluous copy in license checker (flutter/flutter#167146) 2025-04-15 [email protected] license checker: ignore git sha in dart license (flutter/flutter#167153) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
androidseb
pushed a commit
to androidseb/packages
that referenced
this pull request
Jun 8, 2025
…#9098) flutter/flutter@db68c95...aef4718 2025-04-16 [email protected] [Web] Remove `webOnlyUniformRadii` from `RRect` (flutter/flutter#167237) 2025-04-16 [email protected] Roll Skia from 76cb5d4fba27 to 6627deb65939 (10 revisions) (flutter/flutter#167249) 2025-04-16 [email protected] Adding macrobenchmarks for DDC (flutter/flutter#166617) 2025-04-15 [email protected] Add button icon support for animation duration (flutter/flutter#162667) 2025-04-15 [email protected] Roll Dartdoc to 8.3.3 (flutter/flutter#167231) 2025-04-15 [email protected] Removed superfluous copy in license checker (flutter/flutter#167146) 2025-04-15 [email protected] license checker: ignore git sha in dart license (flutter/flutter#167153) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
FMorschel
pushed a commit
to FMorschel/packages
that referenced
this pull request
Jun 9, 2025
…#9098) flutter/flutter@db68c95...aef4718 2025-04-16 [email protected] [Web] Remove `webOnlyUniformRadii` from `RRect` (flutter/flutter#167237) 2025-04-16 [email protected] Roll Skia from 76cb5d4fba27 to 6627deb65939 (10 revisions) (flutter/flutter#167249) 2025-04-16 [email protected] Adding macrobenchmarks for DDC (flutter/flutter#166617) 2025-04-15 [email protected] Add button icon support for animation duration (flutter/flutter#162667) 2025-04-15 [email protected] Roll Dartdoc to 8.3.3 (flutter/flutter#167231) 2025-04-15 [email protected] Removed superfluous copy in license checker (flutter/flutter#167146) 2025-04-15 [email protected] license checker: ignore git sha in dart license (flutter/flutter#167153) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Ortes
pushed a commit
to Ortes/packages
that referenced
this pull request
Jun 25, 2025
…#9098) flutter/flutter@db68c95...aef4718 2025-04-16 [email protected] [Web] Remove `webOnlyUniformRadii` from `RRect` (flutter/flutter#167237) 2025-04-16 [email protected] Roll Skia from 76cb5d4fba27 to 6627deb65939 (10 revisions) (flutter/flutter#167249) 2025-04-16 [email protected] Adding macrobenchmarks for DDC (flutter/flutter#166617) 2025-04-15 [email protected] Add button icon support for animation duration (flutter/flutter#162667) 2025-04-15 [email protected] Roll Dartdoc to 8.3.3 (flutter/flutter#167231) 2025-04-15 [email protected] Removed superfluous copy in license checker (flutter/flutter#167146) 2025-04-15 [email protected] license checker: ignore git sha in dart license (flutter/flutter#167153) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was the most expensive part of finding the files phase.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.