From f084c55ad0114418eba25b1728bb1b6b143a15a6 Mon Sep 17 00:00:00 2001 From: Stuart Morgan Date: Tue, 12 Sep 2023 14:37:45 -0400 Subject: [PATCH 1/2] [ci] Wait for LUCI test checkin in `release` Avoid the possibilty of the `release` action's wait-for-all-tests step completing before any LUCI tests have even checked in, by first waiting for a known LUCI test to show up. --- .github/workflows/release.yml | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 6fdda449c85..5a74906a915 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -43,6 +43,22 @@ jobs: run: dart pub get working-directory: ${{ github.workspace }}/script/tool + # The next step waits for all tests, but when there are issues with the + # hooks it can take a long time for the tests to even be registered. If + # "Wait on all tests" runs before that happens, it will pass immidiately + # because there doesn't appear to be anything to wait for. To avoid that, + # explicitly wait for one LUCI test by name first. + - name: Wait for test check-in + uses: lewagon/wait-on-check-action@e106e5c43e8ca1edea6383a39a01c5ca495fd812 + with: + ref: ${{ github.sha }} + check-name: 'Linux ci_yaml packages roller' + repo-token: ${{ secrets.GITHUB_TOKEN }} + wait-interval: 30 # seconds + allowed-conclusions: success,neutral + # verbose:true will produce too many logs that hang github actions web UI. + verbose: false + # This workflow should be the last to run. So wait for all the other tests to succeed. - name: Wait on all tests uses: lewagon/wait-on-check-action@e106e5c43e8ca1edea6383a39a01c5ca495fd812 From 57582c4764c41c5d97c2992605d9da72042bece0 Mon Sep 17 00:00:00 2001 From: stuartmorgan Date: Fri, 29 Sep 2023 15:32:32 -0400 Subject: [PATCH 2/2] Typo --- .github/workflows/release.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 5a74906a915..b835e2d6baf 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -45,7 +45,7 @@ jobs: # The next step waits for all tests, but when there are issues with the # hooks it can take a long time for the tests to even be registered. If - # "Wait on all tests" runs before that happens, it will pass immidiately + # "Wait on all tests" runs before that happens, it will pass immediately # because there doesn't appear to be anything to wait for. To avoid that, # explicitly wait for one LUCI test by name first. - name: Wait for test check-in