Skip to content

Commit 52ccde3

Browse files
authored
Merge pull request #657 from dsyme/fix-666
Fix 631
2 parents f654890 + 4f78d3b commit 52ccde3

File tree

2 files changed

+3
-6
lines changed

2 files changed

+3
-6
lines changed

src/fsharp/fsi/fsi.fs

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1513,14 +1513,11 @@ module internal MagicAssemblyResolution =
15131513

15141514
let Install(tcConfigB, tcImports: TcImports, fsiDynamicCompiler: FsiDynamicCompiler, fsiConsoleOutput: FsiConsoleOutput) =
15151515

1516-
let rangeStdin = rangeN Lexhelp.stdinMockFilename 0
1517-
15181516
#if TODO_REWORK_ASSEMBLY_LOAD
15191517
ignore tcConfigB
15201518
ignore tcImports
15211519
ignore fsiDynamicCompiler
15221520
ignore fsiConsoleOutput
1523-
ignore rangeStdin
15241521
{ new System.IDisposable with
15251522
member x.Dispose() = () }
15261523
#else
@@ -2459,7 +2456,7 @@ type FsiEvaluationSession (fsi: FsiEvaluationSessionHostConfig, argv:string[], i
24592456

24602457
/// The single, global interactive checker that can be safely used in conjunction with other operations
24612458
/// on the FsiEvaluationSession.
2462-
let checker = FSharpChecker.Create()
2459+
let checker = FSharpChecker.Create(msbuildEnabled=msbuildEnabled)
24632460

24642461
let (tcGlobals,frameworkTcImports,nonFrameworkResolutions,unresolvedReferences) =
24652462
try

src/fsharp/vs/service.fs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2725,7 +2725,7 @@ type FSharpChecker(referenceResolver, projectCacheSize, keepAssemblyContents, ke
27252725

27262726
let backgroundCompiler = BackgroundCompiler(referenceResolver, projectCacheSize, keepAssemblyContents, keepAllBackgroundResolutions)
27272727

2728-
static let globalInstance = FSharpChecker.Create()
2728+
static let globalInstance = lazy FSharpChecker.Create()
27292729

27302730
// Parse using backgroundCompiler
27312731
let ComputeBraceMatching(filename:string,source,options:FSharpProjectOptions) =
@@ -2996,7 +2996,7 @@ type FSharpChecker(referenceResolver, projectCacheSize, keepAssemblyContents, ke
29962996
bc.ParseFileInProject(filename, source, options)
29972997
|> Async.RunSynchronously
29982998

2999-
static member Instance = globalInstance
2999+
static member Instance = globalInstance.Value
30003000
member internal __.FrameworkImportsCache = backgroundCompiler.FrameworkImportsCache
30013001

30023002

0 commit comments

Comments
 (0)