Skip to content

Add a stackFrameFilter argument to SentryClient's capture #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

tom95
Copy link
Contributor

@tom95 tom95 commented Oct 21, 2018

This change allows filtering sensitive frames on the client or applying custom truncation logic.

I created this in reaction to this discussion: https://forum.sentry.io/t/issue-in-flutter-project-with-stackframe-display-limit-set-to-250/5014/2

Instead of adding complex truncation options that will likely depend on the frameworks you use anyways, I opted to provide a more general callback that could also be used for things like filtering specific frames. In the case of above discussion, we'd simply cut the list passed to us to only send the topmost 250 items.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@tom95
Copy link
Contributor Author

tom95 commented Nov 9, 2018

I signed it!

@yjbanov
Copy link
Contributor

yjbanov commented Nov 9, 2018

This repository was supposed to be moved under https://github.com/flutter/packages but we somehow ended up in a situation where this repository was erased but the other one not populated. I'll find out what's going on. Thanks for the PR! We'll find a way to accept it, hopefully soon 😃

@tom95
Copy link
Contributor Author

tom95 commented Nov 9, 2018

Alright, I was wondering about that :D Please tell me once you figured out where the code should go, I also realized that I have the wrong mail address for the CLA in the commit's stamp, so I'll have to replay the changes anyways.

@yjbanov
Copy link
Contributor

yjbanov commented Nov 9, 2018

@tom95 The repository has been restored. Could you please rebase to kick off Travis and correct the email address for the CLA bot to recheck it?

This allows filtering sensitive frames on the client or applying
custom truncation logic.
@tom95 tom95 force-pushed the feature/stack-frame-filter branch from 406b667 to 750c5d6 Compare November 9, 2018 22:50
@tom95
Copy link
Contributor Author

tom95 commented Nov 9, 2018

I signed it!

@tom95
Copy link
Contributor Author

tom95 commented Nov 9, 2018

Well not entirely sure what's missing now. Mail on the commit should be correctly ending in "@4ed1.com" and it's been added to my github account as well. The corporate CLA has also been signed.

@yjbanov
Copy link
Contributor

yjbanov commented Nov 10, 2018

Maybe it will help if you open a new PR with a freshly authored commit that contains the correct email? Just guessing.

@tom95
Copy link
Contributor Author

tom95 commented Nov 14, 2018

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@tom95
Copy link
Contributor Author

tom95 commented Nov 27, 2018

Hey, what's the status of the PR? Should it be held up by the failing travis build, I am hoping that's just because at the time of the build the CLA was not accepted, at least the log only says "presubmit" failed.

@yjbanov
Copy link
Contributor

yjbanov commented Dec 10, 2018

The CLA is happy with both this PR and #30. Let's close one and merge the other?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants