Fix: Do not throw when Throwable type is not supported for associating errors to a transaction #692
Conversation
…g errors to a transaction
| } catch (exception, stackTrace) { | ||
| _options.logger( | ||
| SentryLevel.info, | ||
| 'Throwable type: ${throwable.runtimeType} is not supported for associating errors to a transaction.', |
There was a problem hiding this comment.
Maybe this should point to the docs, which says which types are not supported? Or maybe include the list of unspported types?
There was a problem hiding this comment.
throwable.runtimeType does the job for now, but indeed a better logging message here would be awesome, I will merge and release for now because it's a bug and later improve it.
| @@ -31,7 +31,7 @@ class Hub { | |||
|
|
|||
| late SentryTracesSampler _tracesSampler; | |||
|
|
|||
| final _WeakMap _throwableToSpan = _WeakMap(); | |||
| late final _WeakMap _throwableToSpan; | |||
There was a problem hiding this comment.
Also FYI: Starting with Dart 2.17 there's a WeakReference.
There was a problem hiding this comment.
will take some time, thanks for pointing out o/
`Instructions and example for changelog`$
To the changelog entry, please add a link to this PR (consider a more descriptive message):` - Do not throw when Throwable type is not supported for associating errors to a transaction(#692)
|
📜 Description
Fix: Do not throw when Throwable type is not supported for associating errors to a transaction
💡 Motivation and Context
Fixes #680
💚 How did you test it?
📝 Checklist
🔮 Next steps