fix(node-core): Apply correct SDK metadata (#17014)

While adding the SDK to the release-registry I noticed that we never
apply the correct metadata to node-core.


64d056a
failing tests show the node-core SDK getting incorrect
`sentry.javascript.node` metadata (from `NodeClient`)


88a975a
applies correct metadata to both SDKs

I was debating changing the underlying `NodeClient` to not automatically
set `sentry.javascript.node` but wasn't sure of the implications so
decided not to.

Author: andreiborza

packages/node-core/src/sdk/index.ts

@@ -1,5 +1,6 @@
 import type { Integration, Options } from '@sentry/core';
 import {
+  applySdkMetadata,
   consoleIntegration,
   consoleSandbox,
   functionToStringIntegration,
@@ -120,6 +121,8 @@ function _init(
     );
   }
 
+  applySdkMetadata(options, 'node-core');
+
   const client = new NodeClient(options);
   // The client is on the current scope, from where it generally is inherited
   getCurrentScope().setClient(client);

packages/node-core/test/sdk/init.test.ts

@@ -1,5 +1,5 @@
 import type { Integration } from '@sentry/core';
-import { logger } from '@sentry/core';
+import { logger, SDK_VERSION } from '@sentry/core';
 import * as SentryOpentelemetry from '@sentry/opentelemetry';
 import { type Mock, afterEach, beforeEach, describe, expect, it, vi } from 'vitest';
 import { getClient } from '../../src/';
@@ -31,6 +31,24 @@ describe('init()', () => {
     vi.clearAllMocks();
   });
 
+  describe('metadata', () => {
+    it('has the correct metadata', () => {
+      init({ dsn: PUBLIC_DSN });
+
+      const client = getClient<NodeClient>();
+
+      expect(client?.getSdkMetadata()).toEqual(
+        expect.objectContaining({
+          sdk: {
+            name: 'sentry.javascript.node-core',
+            version: SDK_VERSION,
+            packages: [{ name: 'npm:@sentry/node-core', version: SDK_VERSION }],
+          },
+        }),
+      );
+    });
+  });
+
   describe('integrations', () => {
     it("doesn't install default integrations if told not to", () => {
       init({ dsn: PUBLIC_DSN, defaultIntegrations: false });

packages/node/src/sdk/index.ts

@@ -1,5 +1,5 @@
 import type { Integration, Options } from '@sentry/core';
-import { hasSpansEnabled } from '@sentry/core';
+import { applySdkMetadata, hasSpansEnabled } from '@sentry/core';
 import type { NodeClient } from '@sentry/node-core';
 import {
   getDefaultIntegrations as getNodeCoreDefaultIntegrations,
@@ -50,6 +50,8 @@ function _init(
   options: NodeOptions | undefined = {},
   getDefaultIntegrationsImpl: (options: Options) => Integration[],
 ): NodeClient | undefined {
+  applySdkMetadata(options, 'node');
+
   const client = initNodeCore({
     ...options,
     // Only use Node SDK defaults if none provided

packages/node/test/sdk/init.test.ts

@@ -1,5 +1,5 @@
 import type { Integration } from '@sentry/core';
-import { logger } from '@sentry/core';
+import { logger, SDK_VERSION } from '@sentry/core';
 import * as SentryOpentelemetry from '@sentry/opentelemetry';
 import { type Mock, type MockInstance, afterEach, beforeEach, describe, expect, it, vi } from 'vitest';
 import { getClient, NodeClient, validateOpenTelemetrySetup } from '../../src/';
@@ -38,6 +38,24 @@ describe('init()', () => {
     vi.clearAllMocks();
   });
 
+  describe('metadata', () => {
+    it('has the correct metadata', () => {
+      init({ dsn: PUBLIC_DSN });
+
+      const client = getClient<NodeClient>();
+
+      expect(client?.getSdkMetadata()).toEqual(
+        expect.objectContaining({
+          sdk: {
+            name: 'sentry.javascript.node',
+            version: SDK_VERSION,
+            packages: [{ name: 'npm:@sentry/node', version: SDK_VERSION }],
+          },
+        }),
+      );
+    });
+  });
+
   describe('integrations', () => {
     it("doesn't install default integrations if told not to", () => {
       init({ dsn: PUBLIC_DSN, defaultIntegrations: false });