Remix - No URL included with issues

[alexblack]

Is there an existing issue for this?

• I have checked for existing issues https://github.com/getsentry/sentry-javascript/issues
• I have reviewed the documentation https://docs.sentry.io/
• I am using the latest SDK release https://github.com/getsentry/sentry-javascript/releases

How do you use Sentry?

Sentry Saas (sentry.io)

Which package are you using?

@sentry/remix

SDK Version

7.17.4

Framework Version

7.17.4

Link to Sentry event

https://sentry.io/organizations/syncwith/issues/3721867878/?project=5880196&referrer=issue-stream

Steps to Reproduce

1. We've integrated Sentry into our remix application, on the server and the client, and with express, as indicated in your instructions (hopefully we didn't make any mistakes)

2. When errors are reported in Sentry, I expected to be able to see the URL that the user was on when the error occured, and the user agent, and other information about the request, like we can with our node Sentry integrations.

See attached screenshot of a remix sentry error with no URL mentioned, and one from our node integration where we get the URL.

I believe we've integrated the express request handler as specified:

const { createRequestHandler } = require('@remix-run/express');
const { wrapExpressCreateRequestHandler } = require('@sentry/remix');

const createSentryRequestHandler =
  wrapExpressCreateRequestHandler(createRequestHandler);
 
  
app.all(
  '*',
  isProduction
    ? createSentryRequestHandler({ build: require('./build') })
    : (req, res, next) => {
        purgeRequireCache();
        const build = require('./build');
        return createSentryRequestHandler({ build, mode: MODE })(
          req,
          res,
          next
        );
      }
);

Expected Result

I expected that sentry would grab the URL and other relevant info from the current request and include it in the error. Note this error occured on the server (node) not client (react).

Actual Result

[alexblack]

All the request headers are missing too, and the user is not identified at all (whereas in Node the user is identified by IP address)

[AbhiPrasad]

Hey thanks for writing in @alexblack! Could you share your Sentry server initialization code?

@onurtemizkan mind taking a look at this when you get the chance?

[alexblack]

@AbhiPrasad thanks, sure on the server we do:

export const initSentry = () => {
  Sentry.init({
    beforeSend,
    dsn: SENTRY_ADDON_DSN,
    tracesSampleRate: 0.05,
    normalizeDepth: 6, // stringify deeper objects
  });
};

[onurtemizkan]

Hi @alexblack! Thanks for reporting.

I was not able to reproduce the issue with a generic Remix/Express project. Could you provide a minimal reproduction so we can debug it?

[alexblack]

Thanks for looking into this. Ok that's good to hear. Can you confirm - that it is expected then that the url, request headers etc, should show up in the server side issues? Do you know which part of the sentry remix config code enables this? Eg is there some chance I missed part of the integration?

…

On Tue, Nov 8, 2022, 4:17 AM Onur Temizkan ***@***.***> wrote: Hi @alexblack <https://github.com/alexblack>! Thanks for reporting. I was not able to reproduce the issue with a generic Remix/Express project. Could you provide a minimal reproduction so we can debug it? — Reply to this email directly, view it on GitHub <#6139 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABELQUURINJMWMA6SV6HUDWHJAE3ANCNFSM6AAAAAARYESTDY> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[onurtemizkan]

@alexblack -- Yes, the URL is expected to show up in the server-side issues since version 7.17.1. (6c8d6c3)

It should work out of the box for document requests, actions and loaders. Only configuration I can think of that may cause this is the beforeSend implementation you are using.

But also, there may be a case in your project that we are missing to enrich captured events with RequestData integration. So, if that's the case, we'll need to reproduce and fix this.

[leandro-gomez]

Hi. I'm experiencing the same in my NestJS/Express application. No url, no headers, no user identified.
Versions 7.18 and 7.17 have the same problem, downgrading to version 7.16.0, however, restored those features.

Maybe this be related to this release, specifically to this PR?

[alexblack]

@onurtemizkan great, how about request headers? should I expect the user to be identified by IP address? Both of these work in node.

Here is a repo that I just created, using remix create, where I do see the URL (which is good) but I don't see any request headers, and the user is not identified by IP address (or at all).

https://github.com/alexblack/sentry-remix-test1