From 5a0adef04ac8ad9d5502c159633002f4818391ed Mon Sep 17 00:00:00 2001 From: Tim Fish Date: Thu, 29 Feb 2024 16:07:35 +0000 Subject: [PATCH 1/2] fix(v8): Remove deprecated tracing config --- packages/bun/src/types.ts | 20 +------------------- packages/deno/src/types.ts | 20 +------------------- 2 files changed, 2 insertions(+), 38 deletions(-) diff --git a/packages/bun/src/types.ts b/packages/bun/src/types.ts index c62e4fe320e3..c7f3eee77bca 100644 --- a/packages/bun/src/types.ts +++ b/packages/bun/src/types.ts @@ -1,4 +1,4 @@ -import type { ClientOptions, Options, TracePropagationTargets } from '@sentry/types'; +import type { ClientOptions, Options } from '@sentry/types'; import type { BunClient } from './client'; import type { BunTransportOptions } from './transports'; @@ -33,24 +33,6 @@ export interface BaseBunOptions { * */ clientClass?: typeof BunClient; - // TODO (v8): Remove this in v8 - /** - * @deprecated Moved to constructor options of the `Http` and `Undici` integration. - * @example - * ```js - * Sentry.init({ - * integrations: [ - * new Sentry.Integrations.Http({ - * tracing: { - * shouldCreateSpanForRequest: (url: string) => false, - * } - * }); - * ], - * }); - * ``` - */ - shouldCreateSpanForRequest?(this: void, url: string): boolean; - /** Callback that is executed when a fatal global error occurs. */ onFatalError?(this: void, error: Error): void; } diff --git a/packages/deno/src/types.ts b/packages/deno/src/types.ts index 50310589666a..4ec05bc83fe4 100644 --- a/packages/deno/src/types.ts +++ b/packages/deno/src/types.ts @@ -1,4 +1,4 @@ -import type { ClientOptions, Options, TracePropagationTargets } from '@sentry/types'; +import type { ClientOptions, Options } from '@sentry/types'; import type { DenoTransportOptions } from './transports'; @@ -24,24 +24,6 @@ export interface BaseDenoOptions { /** Sets an optional server name (device name) */ serverName?: string; - // TODO (v8): Remove this in v8 - /** - * @deprecated Moved to constructor options of the `Http` and `Undici` integration. - * @example - * ```js - * Sentry.init({ - * integrations: [ - * new Sentry.Integrations.Http({ - * tracing: { - * shouldCreateSpanForRequest: (url: string) => false, - * } - * }); - * ], - * }); - * ``` - */ - shouldCreateSpanForRequest?(this: void, url: string): boolean; - /** Callback that is executed when a fatal global error occurs. */ onFatalError?(this: void, error: Error): void; } From c60aaa0e3eb2a74b0b61b0672cbcc143c93ef9ed Mon Sep 17 00:00:00 2001 From: Tim Fish Date: Thu, 29 Feb 2024 16:37:06 +0000 Subject: [PATCH 2/2] oops fix missing types --- packages/bun/src/types.ts | 2 +- packages/deno/src/types.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/bun/src/types.ts b/packages/bun/src/types.ts index c7f3eee77bca..933edef42627 100644 --- a/packages/bun/src/types.ts +++ b/packages/bun/src/types.ts @@ -1,4 +1,4 @@ -import type { ClientOptions, Options } from '@sentry/types'; +import type { ClientOptions, Options, TracePropagationTargets } from '@sentry/types'; import type { BunClient } from './client'; import type { BunTransportOptions } from './transports'; diff --git a/packages/deno/src/types.ts b/packages/deno/src/types.ts index 4ec05bc83fe4..92752c5b9d0b 100644 --- a/packages/deno/src/types.ts +++ b/packages/deno/src/types.ts @@ -1,4 +1,4 @@ -import type { ClientOptions, Options } from '@sentry/types'; +import type { ClientOptions, Options, TracePropagationTargets } from '@sentry/types'; import type { DenoTransportOptions } from './transports';