From 7a6549d34f2f008b58262afe5708d873ae444cd1 Mon Sep 17 00:00:00 2001 From: Onur Temizkan Date: Sun, 17 Mar 2024 15:37:45 +0000 Subject: [PATCH] chore(tests): Remove `--detectOpenHandles` from Jest config. --- .github/workflows/build.yml | 8 +++----- packages/nextjs/test/integration/jest.config.js | 1 - packages/nextjs/test/integration/package.json | 2 +- packages/remix/test/integration/jest.config.js | 1 - 4 files changed, 4 insertions(+), 8 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index fb95a14527e8..3d8562473837 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -906,16 +906,14 @@ jobs: strategy: fail-fast: false matrix: - # For whatever reason, these segfault on Node 18, so we are skipping these for now... - node: [20, 21] + node: [18, 20, 21] remix: [1, 2] # Remix v2 only supports Node 18+, so run Node 14, 16 tests separately include: - node: 14 remix: 1 - # For whatever reason, these segfault on Node 16, so we are skipping these for now... - # - node: 16 - # remix: 1 + - node: 16 + remix: 1 steps: - name: Check out current commit (${{ needs.job_get_metadata.outputs.commit_label }}) uses: actions/checkout@v4 diff --git a/packages/nextjs/test/integration/jest.config.js b/packages/nextjs/test/integration/jest.config.js index e5b9abdfdc31..e9df7b66dc9f 100644 --- a/packages/nextjs/test/integration/jest.config.js +++ b/packages/nextjs/test/integration/jest.config.js @@ -4,7 +4,6 @@ module.exports = { ...baseConfig, testMatch: [`${__dirname}/test/server/**/*.test.ts`], testPathIgnorePatterns: [`${__dirname}/test/client`], - detectOpenHandles: true, forceExit: true, testTimeout: 30000, setupFilesAfterEnv: [`${__dirname}/jest.setup.js`], diff --git a/packages/nextjs/test/integration/package.json b/packages/nextjs/test/integration/package.json index fc93bd5681e4..afb23b2fb6f4 100644 --- a/packages/nextjs/test/integration/package.json +++ b/packages/nextjs/test/integration/package.json @@ -8,7 +8,7 @@ "start": "next start", "pretest": "yarn build", "test:client": "playwright test", - "test:server": "jest --detectOpenHandles --forceExit --runInBand" + "test:server": "jest --forceExit --runInBand" }, "dependencies": { "@sentry/nextjs": "file:../../", diff --git a/packages/remix/test/integration/jest.config.js b/packages/remix/test/integration/jest.config.js index d3173100f47f..82c2059da915 100644 --- a/packages/remix/test/integration/jest.config.js +++ b/packages/remix/test/integration/jest.config.js @@ -4,6 +4,5 @@ module.exports = { ...baseConfig, testMatch: [`${__dirname}/test/server/**/*.test.ts`], testPathIgnorePatterns: [`${__dirname}/test/client`], - detectOpenHandles: true, forceExit: true, };